Improve the chrome://net-export/ UI to more clearly reflect each state |
||||||||||||||
Issue descriptionChrome Version: 59.3040 OS: Desktop What steps will reproduce the problem? Visit chrome://net-export, which has recently deprecated the Export tab on chrome://net-internals Problem 1: No event counter is shown. This means I can't tell whether the events prior to the loading of the page will be in the stored capture. I also can't tell whether the events prior to pushing the "Start logging to disk" button is pressed are going to be in the capture either. The UI text at the bottom of the page implies that nothing from prior to pushing the save button will be recorded. In the old model, loading chrome://net-internals would clearly communicate that all of my data was being logged as soon as I opened that page, giving me more confidence/awareness of what would end up in the resulting log file. Beyond showing the raw "event count", it might be interesting to show the size of the expected log file, so I can tell whether my output is going to be reasonable to share with someone else? Problem #2: The net-export text contains the following string: "INSTRUCTIONS: Start logging, reproduce the problem, and then stop logging. Make sure to send the email before starting to log again. Otherwise, the log will be deleted." It's not clear what "send the email" means-- I /think/ this might mean: "If someone asked you for this file, send it to them now"? But I don't think there's any reason to /assume/ that the transfer mechanism will be email; seems more likely it'd be attached to an Issue in an issue tracker? "Otherwise, the log will be deleted" is also problematic-- this implies that a new log deletes the old one, but that doesn't seem to be the case... unless the user chooses the same filename for the next Save operation?
,
Mar 13 2017
Please do whatever makes sense. Thanks a bunch!
,
Mar 13 2017
,
Mar 16 2017
@ericlawrence: Does the language in https://codereview.chromium.org/2757473002/ work for you?
,
Mar 16 2017
Strings LGTM, thanks! Am I correct to note that the "Advanced" (filtering) options only apply /during/ the capture? If I set "Include credentials" then click "Start Logging", then Stop, then change to "Strip Private Information", then click Email, I'm still emailing my credentials, right?
,
Mar 16 2017
The only apply before the capture - we save stuff to disk while capturing, and don't rewrite it.
,
Mar 16 2017
Yeah, I can see how that could be unclear. * Stripping options are snapshotted once you start logging. * During logging the buttons are disabled so you can't change them * After logging has completed, the buttons become active again (in preparation of starting to log again). On the mobile UI may not be clear that changing the options prior to emailing does not have any effect. Do you think adding words to clarify this is worthwhile? Another option is to redesign the UI workflow and have separate state views which only show actions/options relevant to that state.
,
Mar 16 2017
Renaming "ADVANCED" to "When Logging:" might make it more clear that the options are applied at the point of logging rather than as a different step.
On desktop, the fact that we prompt for the filename at the *start* (rather than the *end*) of the capture helps imply that the options apply from the start, even though the options are actually listed below the "end" button.
I feel like things are a little more confusing on Mobile, because there's no prompt for a filename. There, changing the "state machine" might aid in clarity and eliminate some of the existing text.
Initial State:
[Start Capturing]
{Capture Options}
User hits Start Capturing. Everything disappears except
[Stop Capturing]
"Go do whatever's broken, then come back here..."
User hits Stop button. UI is now:
[Discard This Log]
[Email This Log].
If user selects Discard, we return to the initial state.
If user selects Email, the email flow begins and UI turns to:
[Done]
[Email Again]
... But I'm probably overthinking this? :)
,
Mar 16 2017
Thanks elawrence, that UI state flow sounds good to me. I agree it will simplify the wording for instructions at each stage, and should be easier for users to follow. I will leave this open as a feature request (since I doubt I will get to it this week), but in the meantime I can land the buggy instruction fixes. For completeness, I will point out that on mobile the initial state can also be the final one (Discard/Email) for the case where there was a preexisting log in the tmp directory from a past session.
,
Mar 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/62a3acd978daee61b3ea99b4cd705d4401203ee3 commit 62a3acd978daee61b3ea99b4cd705d4401203ee3 Author: eroman <eroman@chromium.org> Date: Thu Mar 16 23:52:51 2017 Cosmetic changes to chrome://net-export, primarily for desktop mode. * On the desktop UI, remove reference to emailing from the instructions (as that is only available from the mobile version). * While logging is in progress, change the disabled button's text from: "Start Logging to Disk" to "Logging to Disk..." This gives a bit more feedback that something is happening (even better would be to show the path to log file and its size) * Add a <title> for the page of "Network Log Export" BUG= 701033 , 701993 Review-Url: https://codereview.chromium.org/2757473002 Cr-Commit-Position: refs/heads/master@{#457612} [modify] https://crrev.com/62a3acd978daee61b3ea99b4cd705d4401203ee3/chrome/browser/ui/webui/net_export_ui.cc [modify] https://crrev.com/62a3acd978daee61b3ea99b4cd705d4401203ee3/components/net_log/resources/net_export.css [modify] https://crrev.com/62a3acd978daee61b3ea99b4cd705d4401203ee3/components/net_log/resources/net_export.html [modify] https://crrev.com/62a3acd978daee61b3ea99b4cd705d4401203ee3/components/net_log/resources/net_export.js
,
Mar 17 2017
I did a quick prototyped of the desktop flow, screenshots attached. (Main difference with mobile version would be the final state has an email button, and the Start Over button would be named Discard.)
,
Apr 18 2017
@ericlawrence: ping - any opinion on comment #11?
,
Apr 26 2017
Targeting this for M60.
,
Apr 26 2017
Issue 702034 has been merged into this issue.
,
May 1 2017
Here is what it looks like in the proposed https://codereview.chromium.org/2850253002. I incorporated elawrence's feedback up to comment #13. The only difference should be that I retained the "Start over" button on mobile, rather than switching to a "Discard this log". This is just an artifact of how I wanted to break up the CLs (didn't want to make feature additions to the C++ controller). I agree it is better to be explicit on the discarding, I can address that an other mobile tweaks on follow-ups.
,
May 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/912ec7d24049de83f175b212da8233edf78a30e2 commit 912ec7d24049de83f175b212da8233edf78a30e2 Author: eroman <eroman@chromium.org> Date: Tue May 02 21:45:45 2017 Change chrome://net-export/ UI flow. Instead of an all-in-one page displaying the current state and disabled future states, splits the user journey among separate screens, each with their own instructions. BUG= 701033 Review-Url: https://codereview.chromium.org/2850253002 Cr-Commit-Position: refs/heads/master@{#468783} [modify] https://crrev.com/912ec7d24049de83f175b212da8233edf78a30e2/components/net_log/net_log_file_writer.cc [modify] https://crrev.com/912ec7d24049de83f175b212da8233edf78a30e2/components/net_log/resources/net_export.css [modify] https://crrev.com/912ec7d24049de83f175b212da8233edf78a30e2/components/net_log/resources/net_export.html [modify] https://crrev.com/912ec7d24049de83f175b212da8233edf78a30e2/components/net_log/resources/net_export.js
,
May 2 2017
,
May 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ec320021c2dfb503b1b953e834414d1c0c49b375 commit ec320021c2dfb503b1b953e834414d1c0c49b375 Author: eroman <eroman@chromium.org> Date: Wed May 03 16:12:19 2017 Make chrome://net-export/ look better on Mac. In particular the min-height on buttons wasn't working. BUG= 701033 Review-Url: https://codereview.chromium.org/2854863003 Cr-Commit-Position: refs/heads/master@{#468995} [modify] https://crrev.com/ec320021c2dfb503b1b953e834414d1c0c49b375/components/net_log/resources/net_export.css |
||||||||||||||
►
Sign in to add a comment |
||||||||||||||
Comment 1 by eroman@chromium.org
, Mar 13 2017