Minnie - External Camera view is upside down in Tent Tablet Mode |
||||||||||
Issue descriptionChrome Version: 58.0.3029.18 Platform: 9334.9.0 (Official Build) dev-channel veyron_minnie What steps will reproduce the problem? (1) Sign in and connect external web camera (2) Access WEBRTC - http://apprtc.appspot.com/?debug=loopback (3) Turn the device to tablet mode - tent view (screenshot attached) What is the expected result? External Camera View should be straight as it is for the onboard camera view in tent mode What happens instead? External web camera view is upside down in tent mode. (see screenshot) Please use labels and text to provide additional information. For graphics-related bugs, please copy/paste the contents of the about:gpu page at the end of this report.
,
Mar 17 2017
Sheng-hao. Maybe we shouldn't rotate the images if it's an external camera?
,
Mar 20 2017
We assumed that the user can rotate the external camera by themselves. https://cs.chromium.org/chromium/src/media/capture/video/linux/video_capture_device_chromeos.cc?l=120 If it's not the case, we can change the logic to disable rotation for all external cameras.
,
Mar 20 2017
Uploaded CL: https://codereview.chromium.org/2762603002/
,
Mar 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f1ce4f776d2e9018a8d7dbe381658e51c1aa5db8 commit f1ce4f776d2e9018a8d7dbe381658e51c1aa5db8 Author: shenghao <shenghao@chromium.org> Date: Thu Mar 23 11:37:23 2017 Do not rotate frames from external cameras When the frames are from external cameras, do not rotate them even if the device itself is rotated. This way, the user can have a fixed external camera no matter how the CrOS device is rotated. BUG= 701028 TEST=Verified on minnie with a fixed external camera that in tent mode, 90-degree-rotated and 270-degree-rotated mode, the chrome camera app still shows correct preview. Review-Url: https://codereview.chromium.org/2762603002 Cr-Commit-Position: refs/heads/master@{#459048} [modify] https://crrev.com/f1ce4f776d2e9018a8d7dbe381658e51c1aa5db8/media/capture/video/linux/video_capture_device_chromeos.cc [modify] https://crrev.com/f1ce4f776d2e9018a8d7dbe381658e51c1aa5db8/media/capture/video/linux/video_capture_device_chromeos.h
,
Mar 23 2017
,
Mar 24 2017
Tried with below builds and still not see the fix - 1. M58 - 9334.20.0/58.0.3029.36 2. M59 - 9397.0.0/59.0.3049.0
,
Mar 27 2017
It's available since 9399.0.0.
,
Mar 27 2017
Verified with M59 ToT-9404.0.0/59.0.3051.3 Tested with M58 build: 9334.23.0/58.0.3029.39 dev and still see the issue. Will this fix go into M58, if so which build to verify?
,
Mar 27 2017
,
Mar 27 2017
,
Mar 27 2017
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 30 2017
Still see the issue with version 58.0.3029.40/9334.28.0 beta
,
Mar 30 2017
The merge to M58 did not happen yet.
,
Mar 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4374383e095dd01918de6287d46a71f0b4f999c5 commit 4374383e095dd01918de6287d46a71f0b4f999c5 Author: henryhsu <henryhsu@chromium.org> Date: Fri Mar 31 04:25:29 2017 Do not rotate frames from external cameras When the frames are from external cameras, do not rotate them even if the device itself is rotated. This way, the user can have a fixed external camera no matter how the CrOS device is rotated. BUG= 701028 TEST=Verified on minnie with a fixed external camera that in tent mode, 90-degree-rotated and 270-degree-rotated mode, the chrome camera app still shows correct preview. TBR=posciak@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2762603002 Cr-Commit-Position: refs/heads/master@{#459048} (cherry picked from commit f1ce4f776d2e9018a8d7dbe381658e51c1aa5db8) Review-Url: https://codereview.chromium.org/2793493003 Cr-Commit-Position: refs/branch-heads/3029@{#507} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} [modify] https://crrev.com/4374383e095dd01918de6287d46a71f0b4f999c5/media/capture/video/linux/video_capture_device_chromeos.cc [modify] https://crrev.com/4374383e095dd01918de6287d46a71f0b4f999c5/media/capture/video/linux/video_capture_device_chromeos.h
,
Apr 10 2017
Verified with version 58.0.3029.66/9334.40.0 beta-channel minnie |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by pgangishetty@google.com
, Mar 13 2017