Do not rely on finalize in PaymentRequestImpl |
|||
Issue descriptionCode: https://cs.chromium.org/chromium/src/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java?l=372 See reference bug: https://bugs.chromium.org/p/chromium/issues/detail?id=472713 In general, finalizers are not the right way to clean up dependencies and we should figure out a way to introduce an explicit delete call. @boliu, should we consider adding a presubmit check to not allow finalizers?
,
Mar 13 2017
I would be in favor of presubmit
,
Jun 27 2017
,
Oct 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4a5327eb216b27eb50bf8992b99d7217a5724fae commit 4a5327eb216b27eb50bf8992b99d7217a5724fae Author: Mathieu Perreault <mathp@chromium.org> Date: Mon Oct 16 16:19:46 2017 [Payments] Remove usage of finalize in PaymentRequestImpl Bug: 701019 Test: existing Change-Id: I7065763a76de0fc8d4020e893dfc71ac0265d624 Reviewed-on: https://chromium-review.googlesource.com/721240 Commit-Queue: Mathieu Perreault <mathp@chromium.org> Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#509069} [modify] https://crrev.com/4a5327eb216b27eb50bf8992b99d7217a5724fae/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
,
Oct 16 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by rouslan@chromium.org
, Mar 13 2017Labels: Type-Bug
Status: Assigned (was: Untriaged)