New issue
Advanced search Search tips

Issue 701018 link

Starred by 4 users

Issue metadata

Status: Available
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Autofill should use security_state component to decide IsContextSecure

Project Member Reported by est...@chromium.org, Mar 13 2017

Issue description

Autofill code does its own check to determine if the context is insecure and credit card autofill should be disabled, e.g. ChromeAutofillClient::IsContextSecure(). [1]

In  issue 652806 , we decided that it would be reasonable for this behavior to match the omnibox, such that credit card autofill is disabled when the omnibox shows Not Secure, the neutral (i), or a Dangerous state. In //chrome, therefore, IsContextSecure() should use SecurityStateTabHelper to compute a SecurityLevel. Other embedders might want to use their version of SecurityStateTabHelper (if they have one) to do the same.

[1] https://cs.chromium.org/chromium/src/chrome/browser/ui/autofill/chrome_autofill_client.cc?l=341
 

Comment 1 by est...@chromium.org, Nov 10 2017

Labels: Hotlist-EnamelAndFriendsFixIt

Comment 2 by est...@chromium.org, Feb 18 2018

Labels: -Hotlist-EnamelAndFriendsFixIt

Comment 3 by ma...@chromium.org, May 22 2018

Status: Untriaged (was: Available)
Labels: Hotlist-GoodFirstBug
Status: Available (was: Untriaged)
Updated code pointer: https://cs.chromium.org/chromium/src/chrome/browser/ui/autofill/chrome_autofill_client.cc?l=384

Sign in to add a comment