Give Findit editor permission on Rietveld |
|||
Issue descriptionFindit needs editor permission to create a reverting CL for a culprit.
,
Mar 13 2017
Solution finalized with infra team, and CL is sent out for review https://chromium-review.googlesource.com/c/453984/
,
Mar 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/3b0e22c24253f220c4ebd56d97660615ae96d07f commit 3b0e22c24253f220c4ebd56d97660615ae96d07f Author: Shuotao Gao <stgao@chromium.org> Date: Tue Mar 14 20:56:26 2017 [Rietveld] Make Findit able to revert a CL. Two changes here: 1. Give editor permission to the whitelisted emails (Findit is already whitelisted) 2. Add an optional parameter 'no_redirect' to the revert api so that the issue id could be returned to Findit BUG= 700995 Change-Id: Ie89cdf2a1d9be2e2eb0b692de3c266733fd3e422 Reviewed-on: https://chromium-review.googlesource.com/453984 Reviewed-by: Aaron Gable <agable@chromium.org> Commit-Queue: Shuotao Gao <stgao@chromium.org> [modify] https://crrev.com/3b0e22c24253f220c4ebd56d97660615ae96d07f/appengine/chromium_rietveld/codereview/auth_utils.py [modify] https://crrev.com/3b0e22c24253f220c4ebd56d97660615ae96d07f/appengine/chromium_rietveld/codereview/revert_patchset.py [modify] https://crrev.com/3b0e22c24253f220c4ebd56d97660615ae96d07f/appengine/chromium_rietveld/codereview/models.py
,
Mar 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/3b0e22c24253f220c4ebd56d97660615ae96d07f commit 3b0e22c24253f220c4ebd56d97660615ae96d07f Author: Shuotao Gao <stgao@chromium.org> Date: Tue Mar 14 20:56:26 2017 [Rietveld] Make Findit able to revert a CL. Two changes here: 1. Give editor permission to the whitelisted emails (Findit is already whitelisted) 2. Add an optional parameter 'no_redirect' to the revert api so that the issue id could be returned to Findit BUG= 700995 Change-Id: Ie89cdf2a1d9be2e2eb0b692de3c266733fd3e422 Reviewed-on: https://chromium-review.googlesource.com/453984 Reviewed-by: Aaron Gable <agable@chromium.org> Commit-Queue: Shuotao Gao <stgao@chromium.org> [modify] https://crrev.com/3b0e22c24253f220c4ebd56d97660615ae96d07f/appengine/chromium_rietveld/codereview/auth_utils.py [modify] https://crrev.com/3b0e22c24253f220c4ebd56d97660615ae96d07f/appengine/chromium_rietveld/codereview/revert_patchset.py [modify] https://crrev.com/3b0e22c24253f220c4ebd56d97660615ae96d07f/appengine/chromium_rietveld/codereview/models.py
,
Mar 14 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by st...@chromium.org
, Mar 13 2017Status: Assigned (was: Available)