New issue
Advanced search Search tips

Issue 700934 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Automatically dispatch services endpoint to module.

Project Member Reported by d...@chromium.org, Mar 13 2017

Issue description

Currently, LogDog requires users to manually specicify that "/prpc/logdog.Services/..." pRPC calls get dispatched to the services endpoint as an optimization. Fix this, so that the optimization is no longer necessary and that all such calls automatically get dispatched to the services endpoint.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/external/github.com/luci/luci-go.git/+/918f7ea1301278c62d3dcc5af775f60ff5faf7c2

commit 918f7ea1301278c62d3dcc5af775f60ff5faf7c2
Author: dnj <dnj@chromium.org>
Date: Mon Mar 13 23:39:42 2017

Automatically dispatch "services" endpoint.

Currently, LogDog requires users to manually specicify that
"/prpc/logdog.Services/..." pRPC calls get dispatched to the services
endpoint as an optimization. Fix this, so that the optimization is no
longer necessary and that all such calls automatically get dispatched to
the services endpoint.

BUG= chromium:700934 
TEST=None
R=hinoka@chromium.org, iannucci@chromium.org

Review-Url: https://codereview.chromium.org/2743243004

[modify] https://crrev.com/918f7ea1301278c62d3dcc5af775f60ff5faf7c2/logdog/appengine/cmd/coordinator/services/module.cfg

Comment 2 by d...@chromium.org, Mar 13 2017

Status: Fixed (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/154ad1259b6a3be20a5a105da533f45d8c066998

commit 154ad1259b6a3be20a5a105da533f45d8c066998
Author: Dan Jacques <dnj@chromium.org>
Date: Tue Mar 14 02:35:00 2017

Remove explicit service reference.

As of this CL:
https://codereview.chromium.org/2743243004

LogDog application will automatically route all service endpoint calls
to the "services" module, removing the need to explicitly perform this
action. Remote the explicit routing parameter from the bootstrap.

BUG= chromium:700934 
TEST=unit

Change-Id: Ic5d2f6f13a515a64bb2a88249ff08b6135fec3f8
Reviewed-on: https://chromium-review.googlesource.com/454102
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Daniel Jacques <dnj@chromium.org>

[modify] https://crrev.com/154ad1259b6a3be20a5a105da533f45d8c066998/scripts/slave/logdog_bootstrap.py
[modify] https://crrev.com/154ad1259b6a3be20a5a105da533f45d8c066998/scripts/slave/unittests/logdog_bootstrap_test.py

Project Member

Comment 4 by bugdroid1@chromium.org, Mar 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/154ad1259b6a3be20a5a105da533f45d8c066998

commit 154ad1259b6a3be20a5a105da533f45d8c066998
Author: Dan Jacques <dnj@chromium.org>
Date: Tue Mar 14 02:35:00 2017

Remove explicit service reference.

As of this CL:
https://codereview.chromium.org/2743243004

LogDog application will automatically route all service endpoint calls
to the "services" module, removing the need to explicitly perform this
action. Remote the explicit routing parameter from the bootstrap.

BUG= chromium:700934 
TEST=unit

Change-Id: Ic5d2f6f13a515a64bb2a88249ff08b6135fec3f8
Reviewed-on: https://chromium-review.googlesource.com/454102
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Daniel Jacques <dnj@chromium.org>

[modify] https://crrev.com/154ad1259b6a3be20a5a105da533f45d8c066998/scripts/slave/logdog_bootstrap.py
[modify] https://crrev.com/154ad1259b6a3be20a5a105da533f45d8c066998/scripts/slave/unittests/logdog_bootstrap_test.py

Sign in to add a comment