New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 700933 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

ec: Remove CONFIG_CHARGER_BD99955

Project Member Reported by sha...@chromium.org, Mar 13 2017

Issue description

CONFIG_CHARGER_BD99955 is no longer in use on master, so we should remove it and consider changing all *bd9995x* vars to *bd99956* (this part is questionable, maybe not desirable due to churn).
 

Comment 1 by sha...@chromium.org, Mar 13 2017

Owner: frankhu@chromium.org
Status: Assigned (was: Untriaged)
CONFIG options are documented in include/config.h. We want to remove CONFIG_CHARGER_BD99955 and all related code.

Follow the Chromium OS Dev Guide (especially this part -- https://www.chromium.org/chromium-os/developer-guide#TOC-Upload-your-changes-and-get-a-code-review) for info on how to post your CL for code review, once complete.

No rush on this - please take your time to learn how the EC codebase is structured. 
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/63e20eb86328f72e4c6f2707d49d66a55f9ee12e

commit 63e20eb86328f72e4c6f2707d49d66a55f9ee12e
Author: sammiequon <sammiequon@chromium.org>
Date: Mon Apr 10 20:43:26 2017

CrOS: Add success/failure indicators for biod methods with no callback.

A couple methods in biod_client.h do not have any indicators of success or failure. Modify these functions to uses VoidDBusMethodCallbaks so users have some indication of D-Bus failures.

TEST=chromeos_unittests --gtest_filter="BiodClientTest.*"
BUG= 700933 

Review-Url: https://codereview.chromium.org/2799043007
Cr-Commit-Position: refs/heads/master@{#463385}

[modify] https://crrev.com/63e20eb86328f72e4c6f2707d49d66a55f9ee12e/chromeos/dbus/biod/biod_client.cc
[modify] https://crrev.com/63e20eb86328f72e4c6f2707d49d66a55f9ee12e/chromeos/dbus/biod/biod_client.h
[modify] https://crrev.com/63e20eb86328f72e4c6f2707d49d66a55f9ee12e/chromeos/dbus/biod/biod_client_unittest.cc
[modify] https://crrev.com/63e20eb86328f72e4c6f2707d49d66a55f9ee12e/chromeos/dbus/biod/fake_biod_client.cc
[modify] https://crrev.com/63e20eb86328f72e4c6f2707d49d66a55f9ee12e/chromeos/dbus/biod/fake_biod_client.h

Oops, my CL was meant for  crbug.com/709333 .
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/ec/+/902706a2ebc1c51767b882279f558dd2c799e601

commit 902706a2ebc1c51767b882279f558dd2c799e601
Author: Shawn Nematbakhsh <shawnn@chromium.org>
Date: Sat Sep 02 20:01:52 2017

cleanup: Remove duplicate BD9995X CONFIGs

BUG= chromium:700933 
BRANCH=None
TEST=`make buildall -j`

Change-Id: Id76fe93612fcd1ef924d7fa94479c45a52db046b
Signed-off-by: Shawn Nematbakhsh <shawnn@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/648566
Commit-Ready: Shawn N <shawnn@chromium.org>
Tested-by: Shawn N <shawnn@chromium.org>
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>

[modify] https://crrev.com/902706a2ebc1c51767b882279f558dd2c799e601/board/nefario/board.h
[modify] https://crrev.com/902706a2ebc1c51767b882279f558dd2c799e601/board/coral/board.h
[modify] https://crrev.com/902706a2ebc1c51767b882279f558dd2c799e601/driver/charger/bd9995x.h
[modify] https://crrev.com/902706a2ebc1c51767b882279f558dd2c799e601/board/eve/board.h
[modify] https://crrev.com/902706a2ebc1c51767b882279f558dd2c799e601/include/config.h
[modify] https://crrev.com/902706a2ebc1c51767b882279f558dd2c799e601/board/reef_it8320/board.h
[modify] https://crrev.com/902706a2ebc1c51767b882279f558dd2c799e601/board/kevin/board.h
[modify] https://crrev.com/902706a2ebc1c51767b882279f558dd2c799e601/driver/build.mk
[modify] https://crrev.com/902706a2ebc1c51767b882279f558dd2c799e601/driver/charger/bd9995x.c
[modify] https://crrev.com/902706a2ebc1c51767b882279f558dd2c799e601/board/reef/board.h

Cc: -sha...@chromium.org frankhu@chromium.org
Owner: sha...@chromium.org
Status: Verified (was: Assigned)

Sign in to add a comment