New issue
Advanced search Search tips

Issue 700914 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 0
Type: Bug



Sign in to add a comment

Layout tests failing on various platforms after recent set of LERP-related changes and rebaselines

Project Member Reported by blundell@chromium.org, Mar 13 2017

Issue description

On 10.11, the svg/W3C-SVG-1.1/animate-elem-14-t.svg test has been failing since https://codereview.chromium.org/2731393002.

On 10.9 and 10.10, virtual/mojo-loading/http/tests/webfont/popup-menu-load-webfont-after-open.html has been failing since https://codereview.chromium.org/2744203002.

I'm not sure what's needed here: more rebaselining?
  
 
Summary: Layout tests failing on various platforms after recent set of LERP-related changes and rebaselines (was: Mac layout tests failing after recent set of LERP-related changes and rebaselines)
It looks like the Win7 failures are also related?

The failures started on this build: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7/builds/50977, which has https://codereview.chromium.org/2731393002 in it. The failing tests are the following:

fast/table/backgr_position-table-row-collapsed-border.html
fast/table/backgr_border-table-row-collapsed-border.html
fast/table/backgr_simple-table-row-collapsed-border.html
virtual/mojo-loading/http/tests/inspector/network/waterfall-images.html
fast/table/backgr_simple-table-cell-collapsed-border.html
fast/table/backgr_simple-table-cell.html
http/tests/inspector/network/waterfall-images.html
fast/table/backgr_simple-table-column-group.html
fast/table/backgr_position-table-column-group-collapsed-border.html

The Win7 Dbg bot is having the same problems as listed above for the Win7 bot, starting with the same CL:

https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29/builds/9259
Status: Started (was: Assigned)
Thanks.  It's likely that I missed cleaning up some of these.  I'll suppress and re-rebaseline.
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d7712e4988855165151047078508b75f2cdee8cd

commit d7712e4988855165151047078508b75f2cdee8cd
Author: fmalita <fmalita@chromium.org>
Date: Mon Mar 13 14:55:28 2017

Suppress layout tests failing after SK_SUPPORT_LEGACY_BROKEN_LERP change

Pending rebaseline.

BUG= 700914 
TBR=blundell@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2746943002
Cr-Commit-Position: refs/heads/master@{#456379}

[modify] https://crrev.com/d7712e4988855165151047078508b75f2cdee8cd/third_party/WebKit/LayoutTests/TestExpectations

It may also be possible that flakiness on Linux in the test "fast/forms/select/input-select-after-resize.html" is related to this, since the start of flakiness coincides with https://codereview.chromium.org/2731393002 ("Remove SK_SUPPORT_LEGACY_BROKEN_LERP").
qyearsley@ yup, looks related.  With so many timeouts, no wonder the mega rebaseline didn't pick up correct results for it.

I'll throw in a Trusty/input-select-after-resize.html rebaseline with the others.
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5052d1d653fdd1965ed4d9d66973b76bb8b48466

commit 5052d1d653fdd1965ed4d9d66973b76bb8b48466
Author: fmalita <fmalita@chromium.org>
Date: Mon Mar 13 18:36:08 2017

More rebaselines after SK_SUPPORT_LEGACY_BROKEN_LERP change

BUG= 700914 
TBR=blundell@chromium.org

Review-Url: https://codereview.chromium.org/2746953002
Cr-Commit-Position: refs/heads/master@{#456440}

[modify] https://crrev.com/5052d1d653fdd1965ed4d9d66973b76bb8b48466/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/5052d1d653fdd1965ed4d9d66973b76bb8b48466/third_party/WebKit/LayoutTests/platform/linux/fast/forms/select/input-select-after-resize-expected.png
[add] https://crrev.com/5052d1d653fdd1965ed4d9d66973b76bb8b48466/third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/mojo-loading/http/tests/webfont/popup-menu-load-webfont-after-open-expected.png
[add] https://crrev.com/5052d1d653fdd1965ed4d9d66973b76bb8b48466/third_party/WebKit/LayoutTests/platform/mac-mac10.9/virtual/mojo-loading/http/tests/webfont/popup-menu-load-webfont-after-open-expected.png
[delete] https://crrev.com/b49a2e096ddc3e25765aeaafacff8dc5434ea20e/third_party/WebKit/LayoutTests/platform/mac-retina/svg/W3C-SVG-1.1/animate-elem-14-t-expected.png
[modify] https://crrev.com/5052d1d653fdd1965ed4d9d66973b76bb8b48466/third_party/WebKit/LayoutTests/platform/win7/fast/table/backgr_border-table-row-collapsed-border-expected.png
[modify] https://crrev.com/5052d1d653fdd1965ed4d9d66973b76bb8b48466/third_party/WebKit/LayoutTests/platform/win7/fast/table/backgr_position-table-column-group-collapsed-border-expected.png
[modify] https://crrev.com/5052d1d653fdd1965ed4d9d66973b76bb8b48466/third_party/WebKit/LayoutTests/platform/win7/fast/table/backgr_position-table-row-collapsed-border-expected.png
[modify] https://crrev.com/5052d1d653fdd1965ed4d9d66973b76bb8b48466/third_party/WebKit/LayoutTests/platform/win7/fast/table/backgr_simple-table-cell-collapsed-border-expected.png
[modify] https://crrev.com/5052d1d653fdd1965ed4d9d66973b76bb8b48466/third_party/WebKit/LayoutTests/platform/win7/fast/table/backgr_simple-table-cell-expected.png
[modify] https://crrev.com/5052d1d653fdd1965ed4d9d66973b76bb8b48466/third_party/WebKit/LayoutTests/platform/win7/fast/table/backgr_simple-table-column-group-expected.png
[modify] https://crrev.com/5052d1d653fdd1965ed4d9d66973b76bb8b48466/third_party/WebKit/LayoutTests/platform/win7/fast/table/backgr_simple-table-row-collapsed-border-expected.png
[delete] https://crrev.com/b49a2e096ddc3e25765aeaafacff8dc5434ea20e/third_party/WebKit/LayoutTests/platform/win7/http/tests/inspector/network/waterfall-images-expected.png
[delete] https://crrev.com/b49a2e096ddc3e25765aeaafacff8dc5434ea20e/third_party/WebKit/LayoutTests/platform/win7/virtual/mojo-loading/http/tests/inspector/network/waterfall-images-expected.png
[delete] https://crrev.com/b49a2e096ddc3e25765aeaafacff8dc5434ea20e/third_party/WebKit/LayoutTests/virtual/mojo-loading/http/tests/inspector/network/waterfall-images-expected.png

Project Member

Comment 8 by bugdroid1@chromium.org, Mar 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ea599a2efa9c9ea8ae036d26f684957d05748f41

commit ea599a2efa9c9ea8ae036d26f684957d05748f41
Author: fmalita <fmalita@chromium.org>
Date: Tue Mar 14 13:44:52 2017

Manual rebaseline for input-select-after-resize/Win7

One more rebaseline after SK_SUPPORT_LEGACY_BROKEN_LERP change.

BUG= 700914 
TBR=qyearsley@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2750643003
Cr-Commit-Position: refs/heads/master@{#456690}

[delete] https://crrev.com/b564548ad17fbddb292f135951aefcbde141e400/third_party/WebKit/LayoutTests/platform/win7/fast/forms/select/input-select-after-resize-expected.png

Status: Fixed (was: Started)
All the above should be fixed at this point.

Sign in to add a comment