New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 700913 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Aug 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

16.4%-29.9% regression in blink_perf.dom at 455056:455781

Project Member Reported by hjd@chromium.org, Mar 13 2017

Issue description

See the link to graphs below.
 

Comment 1 by hjd@chromium.org, Mar 13 2017

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=700913

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDglIHItwkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgtJ7koQoM


Bot(s) for this bug's original alert(s):

chromium-rel-win7-gpu-intel
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Mar 13 2017

Cc: reed@google.com
Owner: reed@google.com

=== Auto-CCing suspected CL author reed@google.com ===

Hi reed@google.com, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Mike Reed
  Commit : 84dd85793560769e9628d0a767cb50a4234c572a
  Date   : Thu Mar 09 14:59:32 2017
  Subject: make GrPaint.h private -- IWYU

Bisect Details
  Configuration: winx64intel_perf_bisect
  Benchmark    : blink_perf.dom
  Metric       : remove_child_with_selection/remove_child_with_selection
  Change       : 5.76% | 1.49855555556 -> 1.58488888889

Revision                             Result                    N
chromium@455055                      1.49856 +- 0.160469       9      good
chromium@455418                      1.50483 +- 0.0882884      6      good
chromium@455600                      1.47417 +- 0.0232988      6      good
chromium@455691                      1.519 +- 0.0168523        6      good
chromium@455736                      1.5305 +- 0.0277038       6      good
chromium@455759                      1.51183 +- 0.0332691      6      good
chromium@455770                      1.49767 +- 0.0242762      6      good
chromium@455776                      1.5255 +- 0.0253673       6      good
chromium@455778                      1.5135 +- 0.0497946       6      good
chromium@455778,skia@4a21c94f40      1.502 +- 0.0161864        6      good
chromium@455778,skia@84dd857935      1.583 +- 0.034            6      bad       <--
chromium@455779                      1.58983 +- 0.0618452      6      bad
chromium@455781                      1.58489 +- 0.0336584      9      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests blink_perf.dom

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8985229232160241888

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5773031814725632


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!

Comment 4 by hjd@chromium.org, Mar 14 2017

Status: Assigned (was: Untriaged)
Hmm, I'm surprised bisect blamed this CL, there is a likely culprit CL in the range:
(https://chromium.googlesource.com/chromium/src/+/5e921f820bc0a86566e25b279019ba965535230e).
If you don't think this was your CL reassign to me and I will dupe to the right bug.
Status: WontFix (was: Assigned)
Looks like this recovered.

Sign in to add a comment