New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 700907 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 711464
Owner:
OoO until Feb 4th
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

bindings: Set a maximum size for an union name

Project Member Reported by raphael....@intel.com, Mar 13 2017

Issue description

Spun off this review comment: https://codereview.chromium.org/2746713003/diff/1/third_party/WebKit/Source/bindings/tests/results/core/NodeOrLongSequenceOrEventOrXMLHttpRequestOrStringOrStringByteStringOrNodeListRecord.h

"IIUC this kind of too long file name is problematic on Windows
(crbug.com/611437). We have utilities.shorten_union_name() to work around the
problem.

I think we should check the length of a given union type and throw an exception
if it's too long (100 characters?) but doesn't have an alias."

I don't have access to issue 611437, but it seems to be yet another case of Windows causing headaches due to path size limitations.

Setting a maximum threshold for a union name should alleviate the pain, but it's not clear if utilities.shorten_union_name() should do that or if that check should be done somewhere else.
 
I cced you on 611437.

Thanks. Also related and mentioned in that CL review:  issue 611545 , which should render this bug moot.
Owner: raphael....@intel.com

Comment 4 by peria@chromium.org, Jul 14 2017

Mergedinto: 711464
Status: Duplicate (was: Available)

Sign in to add a comment