New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 700903 link

Starred by 1 user
Status: Verified
Owner:
yhanada@chromium.org
Closed: Mar 2017
Cc:
█ yoshiki@chromium.org
peter@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Settings button on notification remain active when clicked and hover out

Project Member Reported by yhanada@chromium.org, Mar 13 2017 
Ripple should fade out once completed.

Internal bug: b/36000828

The fix was submitted already (crrev.com/2734153002).
This issue is created for requesting merge.
Project Member

Comment 1 by sheriffbot@chromium.org, Mar 14 2017

Labels: -Merge-Request-58 Hotlist-Merge-Approved Merge-Approved-58
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), bhthompson@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 16 2017

Labels: -merge-approved-58 merge-merged-3029
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/62cac5ce05789689c72fe9004b4a705397b1569e

commit 62cac5ce05789689c72fe9004b4a705397b1569e
Author: yoshiki iguchi <yoshiki@chromium.org>
Date: Thu Mar 16 05:11:04 2017

Remove ink drop effect after clicking the settings button on an ARC notification.

BUG=b/36000828
BUG= 700903 

Review-Url: https://codereview.chromium.org/2734153002
Cr-Commit-Position: refs/heads/master@{#455318}
(cherry picked from commit fea9ebc8a336166c3c130aa00fa64a72d55d9bec)

Review-Url: https://codereview.chromium.org/2756653002 .
Cr-Commit-Position: refs/branch-heads/3029@{#225}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/62cac5ce05789689c72fe9004b4a705397b1569e/ui/arc/notification/arc_custom_notification_view.cc
[modify] https://crrev.com/62cac5ce05789689c72fe9004b4a705397b1569e/ui/arc/notification/arc_custom_notification_view.h

Comment 3 by yoshiki@chromium.org, Mar 16 2017 

Merged, on behalf of yhanada@.

Comment 4 by yhanada@chromium.org, Mar 16 2017

Status: Fixed (was: Assigned)
Thanks!

Comment 5 by sdantul...@chromium.org, Apr 5 2017

Status: Verified (was: Fixed)
9334.33.0 / 58.0.3029.51
►

Sign in to add a comment