Add a LayoutTest for a partially loaded APNG |
|||||
Issue descriptionAPNG support ( issue 437662 ) is in progress at https://codereview.chromium.org/2618633004/ From that review (https://codereview.chromium.org/2618633004/diff/240001/third_party/WebKit/Source/platform/image-decoders/png/PNGImageDecoder.cpp#newcode486): "could we add a test for that in the animated image case please? A bug about it would be enough. You would add a HTTP layout test using the load-and-stall script, see for example: LayoutTests/http/tests/images/png-partial-load.html LayoutTests/http/tests/images/jpeg-partial-load.html"
,
Mar 13 2017
>https://crrev.com/427dfb952160b6402103f5db70a0e3dc6c5c500d/third_party/WebKit/LayoutTests/images/resources/count-down-color-test.gif Ahem, that's a GIF, meant the APNG image of course ... https://chromium.googlesource.com/chromium/src/+/427dfb952160b6402103f5db70a0e3dc6c5c500d/third_party/WebKit/LayoutTests/images/resources/count-down-color-test.png
,
Mar 16 2017
,
Mar 16 2017
,
Mar 16 2017
,
Mar 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2ef26ee13e1d61e0d52daf64bd4ad2ef7a7907d5 commit 2ef26ee13e1d61e0d52daf64bd4ad2ef7a7907d5 Author: noel <noel@chromium.org> Date: Thu Mar 16 21:44:07 2017 Add a partial load test for an animated PNG image Use HTTP test load-and-stall script to partially load the initial frame of a animated PNG image. Render the image over CSS background color green and confirm that the CSS color appears in the undecoded regions of the image. BUG= 700892 Review-Url: https://codereview.chromium.org/2743253009 Cr-Commit-Position: refs/heads/master@{#457569} [modify] https://crrev.com/2ef26ee13e1d61e0d52daf64bd4ad2ef7a7907d5/third_party/WebKit/LayoutTests/TestExpectations [add] https://crrev.com/2ef26ee13e1d61e0d52daf64bd4ad2ef7a7907d5/third_party/WebKit/LayoutTests/http/tests/images/png-animated-partial-load.html
,
Mar 16 2017
Results look good, watching it run around the bots for some number of cycles to check results are stable (not flakey).
,
Mar 16 2017
> Ahem, that's a GIF, meant the APNG image of course ... And we should add a test for an animated GIF too, since APNG and GIF test coverage came up while reviewing https://codereview.chromium.org/2749703002 bug 701143 . Animated GIF case done on bug 702148 .
,
Mar 17 2017
#7 Stability looks good.
,
Mar 17 2017
Result looks good, CSS green background color visible in undecoded parts of the image.
,
Mar 17 2017
,
Mar 17 2017
This to cover any changes in https://codereview.chromium.org/2749703002 and the patch split out from there. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by noel@chromium.org
, Mar 13 2017