Merge new jitter buffer fix to M58 |
||||||
Issue descriptionA bug was found that cause the new video jitter buffer to crash in case of the same frame being inserted twice. Here is the bug fix: https://codereview.webrtc.org/2734453002
,
Mar 14 2017
Oops, specified OS.
,
Mar 14 2017
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), bhthompson@(cros), govind@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 14 2017
Your change is approved for M58. Please ensure whether this fix is verified in canary. If yes, please merge ASAP so that it will be picked up for Beta promotion RC cut on 03/15 at 5.00 PM PST.
,
Mar 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/external/webrtc.git/+/a5544b699f03739f4f237af114dcfd76ba4e586e commit a5544b699f03739f4f237af114dcfd76ba4e586e Author: philipel <philipel@webrtc.org> Date: Wed Mar 15 10:13:37 2017 Drop VP8 frames in case of duplicates in RtpFrameReferenceFinder. BUG= webrtc:5514 , chromium:700879 Review-Url: https://codereview.webrtc.org/2734453002 Cr-Commit-Position: refs/heads/master@{#17090} (cherry picked from commit 57f19cc0cdd295ec409b0a05b67c0e993419f181) R=holmer@chromium.org, stefan@webrtc.org Review-Url: https://codereview.webrtc.org/2750823003 . Cr-Commit-Position: refs/branch-heads/58@{#3} Cr-Branched-From: f31969a584bcafe9406c214a9d4c3afb49d19650-refs/heads/master@{#16937} [modify] https://crrev.com/a5544b699f03739f4f237af114dcfd76ba4e586e/webrtc/modules/video_coding/rtp_frame_reference_finder.cc [modify] https://crrev.com/a5544b699f03739f4f237af114dcfd76ba4e586e/webrtc/modules/video_coding/rtp_frame_reference_finder_unittest.cc
,
Mar 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/external/webrtc.git/+/a5544b699f03739f4f237af114dcfd76ba4e586e commit a5544b699f03739f4f237af114dcfd76ba4e586e Author: philipel <philipel@webrtc.org> Date: Wed Mar 15 10:13:37 2017 Drop VP8 frames in case of duplicates in RtpFrameReferenceFinder. BUG= webrtc:5514 , chromium:700879 Review-Url: https://codereview.webrtc.org/2734453002 Cr-Commit-Position: refs/heads/master@{#17090} (cherry picked from commit 57f19cc0cdd295ec409b0a05b67c0e993419f181) R=holmer@chromium.org, stefan@webrtc.org Review-Url: https://codereview.webrtc.org/2750823003 . Cr-Commit-Position: refs/branch-heads/58@{#3} Cr-Branched-From: f31969a584bcafe9406c214a9d4c3afb49d19650-refs/heads/master@{#16937} [modify] https://crrev.com/a5544b699f03739f4f237af114dcfd76ba4e586e/webrtc/modules/video_coding/rtp_frame_reference_finder.cc [modify] https://crrev.com/a5544b699f03739f4f237af114dcfd76ba4e586e/webrtc/modules/video_coding/rtp_frame_reference_finder_unittest.cc
,
Mar 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/external/webrtc.git/+/a5544b699f03739f4f237af114dcfd76ba4e586e commit a5544b699f03739f4f237af114dcfd76ba4e586e Author: philipel <philipel@webrtc.org> Date: Wed Mar 15 10:13:37 2017 Drop VP8 frames in case of duplicates in RtpFrameReferenceFinder. BUG= webrtc:5514 , chromium:700879 Review-Url: https://codereview.webrtc.org/2734453002 Cr-Commit-Position: refs/heads/master@{#17090} (cherry picked from commit 57f19cc0cdd295ec409b0a05b67c0e993419f181) R=holmer@chromium.org, stefan@webrtc.org Review-Url: https://codereview.webrtc.org/2750823003 . Cr-Commit-Position: refs/branch-heads/58@{#3} Cr-Branched-From: f31969a584bcafe9406c214a9d4c3afb49d19650-refs/heads/master@{#16937} [modify] https://crrev.com/a5544b699f03739f4f237af114dcfd76ba4e586e/webrtc/modules/video_coding/rtp_frame_reference_finder.cc [modify] https://crrev.com/a5544b699f03739f4f237af114dcfd76ba4e586e/webrtc/modules/video_coding/rtp_frame_reference_finder_unittest.cc
,
Mar 15 2017
,
Mar 15 2017
Thanks for the merge. If there is no pending work, please remov - Merge-Approved-58 label.
,
Mar 16 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by gov...@chromium.org
, Mar 13 2017