New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 700879 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2017
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

Merge new jitter buffer fix to M58

Project Member Reported by philipel@chromium.org, Mar 13 2017

Issue description

A bug was found that cause the new video jitter buffer to crash in case of the same frame being inserted twice.

Here is the bug fix: https://codereview.webrtc.org/2734453002
 

Comment 1 by gov...@chromium.org, Mar 13 2017

Pls apply appropriate OS labels. Thank you.
Labels: OS-All
Oops, specified OS.
Project Member

Comment 3 by sheriffbot@chromium.org, Mar 14 2017

Labels: -Merge-Request-58 Hotlist-Merge-Approved Merge-Approved-58
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), bhthompson@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Your change is approved for M58. Please ensure whether this fix is verified in canary. If yes, please merge ASAP so that it will be picked up for Beta promotion RC cut on 03/15 at 5.00 PM PST.
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 15 2017

Labels: merge-merged-58
The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/a5544b699f03739f4f237af114dcfd76ba4e586e

commit a5544b699f03739f4f237af114dcfd76ba4e586e
Author: philipel <philipel@webrtc.org>
Date: Wed Mar 15 10:13:37 2017

Drop VP8 frames in case of duplicates in RtpFrameReferenceFinder.

BUG= webrtc:5514 ,  chromium:700879 

Review-Url: https://codereview.webrtc.org/2734453002
Cr-Commit-Position: refs/heads/master@{#17090}
(cherry picked from commit 57f19cc0cdd295ec409b0a05b67c0e993419f181)

R=holmer@chromium.org, stefan@webrtc.org

Review-Url: https://codereview.webrtc.org/2750823003 .
Cr-Commit-Position: refs/branch-heads/58@{#3}
Cr-Branched-From: f31969a584bcafe9406c214a9d4c3afb49d19650-refs/heads/master@{#16937}

[modify] https://crrev.com/a5544b699f03739f4f237af114dcfd76ba4e586e/webrtc/modules/video_coding/rtp_frame_reference_finder.cc
[modify] https://crrev.com/a5544b699f03739f4f237af114dcfd76ba4e586e/webrtc/modules/video_coding/rtp_frame_reference_finder_unittest.cc

Project Member

Comment 6 by bugdroid1@chromium.org, Mar 15 2017

Project Member

Comment 7 by bugdroid1@chromium.org, Mar 15 2017

Status: Fixed (was: Untriaged)
Thanks for the merge. 

If there is no pending work, please remov - Merge-Approved-58 label.
Labels: -Merge-Approved-58

Sign in to add a comment