New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 700868 link

Starred by 2 users

Fix test failure introduced by https://codereview.chromium.org/2739683006

Project Member Reported by blundell@chromium.org, Mar 13 2017

Issue description

https://codereview.chromium.org/2739683006 introduced a test failure on Android: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29/builds/62131.

I would ordinarily revert the CL but it doesn't revert cleanly as https://codereview.chromium.org/2735703005 landed afterward, and I don't have enough domain expertise to know whether these two patches are related or independent. As a result I'm just disabling the test on Android. This however means that the bug is still present in the tree. Please either perform the necessary revert(s) or fix the test ASAP.
 
Cc: glebl@chromium.org yoichio@chromium.org
 Issue 700804  has been merged into this issue.
The test disable is going through CQ now: https://codereview.chromium.org/2748683002/
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2ac5618843f8e7b3044b9931c571d45aaf2915ca

commit 2ac5618843f8e7b3044b9931c571d45aaf2915ca
Author: blundell <blundell@chromium.org>
Date: Mon Mar 13 13:21:05 2017

Disable NGTextLayoutAlgorithmTest.TextFloatsAroundFloatsBefore on Android

https://codereview.chromium.org/2739683006 introduced a test failure on
Android:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29/builds/62131.

I would ordinarily revert the CL but it doesn't revert cleanly as
https://codereview.chromium.org/2735703005 landed afterward, and I don't have
enough domain expertise to know whether these two patches are related or
independent. As a result I'm just disabling the test on Android. This however
means that the bug is still present in the tree, so  crbug.com/700868  needs
to be fixed ASAP.

BUG= 700868 
TBR=glebl

Review-Url: https://codereview.chromium.org/2748683002
Cr-Commit-Position: refs/heads/master@{#456361}

[modify] https://crrev.com/2ac5618843f8e7b3044b9931c571d45aaf2915ca/third_party/WebKit/Source/core/layout/ng/ng_text_layout_algorithm_test.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Mar 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fdda6d5acfde5d7083995597ddddeb08588728cd

commit fdda6d5acfde5d7083995597ddddeb08588728cd
Author: glebl <glebl@chromium.org>
Date: Mon Mar 13 20:31:44 2017

Re-enable TextFloatsAroundFloatsBefore and check left offsets only

http://crrev.com/2739683006 broke one of downstream bots
"WebKit Android (Nexus4)"
Here is the bot's output
  Value of: inline_text_box2->frameRect().location()
   Actual: "30,23"
  Expected: LayoutPoint(30, 22)
   Which is: "30,22"
  Value of: inline_text_box3->frameRect().location()
   Actual: "0,46"
  Expected: LayoutPoint(0, 44)
   Which is: "0,44"

I think it happened because of the difference in sizes between
different fallback fonts on different platforms. I don't have
permissions to run a downstream bot

$ git cl try -m master.chromium.webkit -b "WebKit Android (Nexus4)"
ERROR: Access denied: User user:glebl@chromium.org cannot
add builds to bucket master.chromium.webkit

But it's clear that the test failed while checking the height.

This patch re-enable TextFloatsAroundFloatsBefore and make it to check
what matters, i.e. left offsets.

BUG= 700868 

Review-Url: https://codereview.chromium.org/2744213004
Cr-Commit-Position: refs/heads/master@{#456467}

[modify] https://crrev.com/fdda6d5acfde5d7083995597ddddeb08588728cd/third_party/WebKit/Source/core/layout/ng/ng_text_layout_algorithm_test.cc

Project Member

Comment 5 by sheriffbot@chromium.org, Mar 27 2017

Cc: gkihumba@chromium.org dimu@google.com maxkirsch@chromium.org gkihumba@google.com yueherngl@chromium.org hirono@chromium.org bhthompson@chromium.org krishna...@chromium.org cma...@chromium.org kkhorimoto@chromium.org tienchang@chromium.org ligim...@chromium.org moch@chromium.org sshru...@google.com ketakid@google.com awhalley@chromium.org keta...@chromium.org ntang@google.com marcheu@google.com reve...@chromium.org bhthompson@google.com gov...@chromium.org hablich@chromium.org jbau...@chromium.org vsu...@chromium.org carusom@chromium.org dimu@chromium.org kinuko@chromium.org tin...@google.com
Pri-0 bugs are critical regressions or serious emergencies, and this bug has not been updated in three days. Could you please provide an update, or adjust the priority to a more appropriate level if applicable?

If a fix is in active development, please set the status to Started.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 6 by moch@chromium.org, Mar 27 2017

Cc: -moch@chromium.org

Comment 7 by glebl@chromium.org, Mar 27 2017

Status: Fixed (was: Assigned)
Cc: -hablich@chromium.org

Sign in to add a comment