New issue
Advanced search Search tips

Issue 700857 link

Starred by 1 user
Status: Fixed
Owner:
grt@chromium.org
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

TryChromeDialog appears on wrong monitor when taskbar is hidden

Project Member Reported by grt@chromium.org, Mar 13 2017 
To repro:

- position two monitors one over the other
- make the top monitor the primary
- set the taskbar to auto-hide
- launch chrome to show the dialog:
  chrome.exe --try-chrome-again=0
- notice that the dialog appears partially offscreen of the secondary (bottom) monitor
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b2dd7ef5625c8ab415c1257d53b7a721dfffc344

commit b2dd7ef5625c8ab415c1257d53b7a721dfffc344
Author: grt <grt@chromium.org>
Date: Tue Mar 14 10:08:22 2017

Fix the positioning of the TryChromeDialog when the taskbar is hidden.

In cases of multi-monitor, MonitorFromWindow may return a secondary
monitor depending on the orientation of the monitors, so simply position
the window based on the work area of the primary monitor.

Also fixes a bug in the panic fallback that was improperly increasing
the size of the dialog.

BUG= 700857 
R=huangs@chromium.org

Review-Url: https://codereview.chromium.org/2742343002
Cr-Commit-Position: refs/heads/master@{#456664}

[modify] https://crrev.com/b2dd7ef5625c8ab415c1257d53b7a721dfffc344/chrome/browser/first_run/try_chrome_dialog_view.cc
[modify] https://crrev.com/b2dd7ef5625c8ab415c1257d53b7a721dfffc344/chrome/browser/first_run/try_chrome_dialog_view.h

Comment 2 by grt@chromium.org, Apr 19 2017

Status: Fixed (was: Started)
►

Sign in to add a comment