Issue metadata
Sign in to add a comment
|
input does not fire onchange event for a previously entered value which was dynamically changed when hitting ENTER
Reported by
jammoul....@gmail.com,
Mar 13 2017
|
||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2924.87 Safari/537.36 Steps to reproduce the problem: 1. User enters "A" in input type="text" 2. User hits ENTER key 2. onchange handler dynamically sets input's value to "B" 3. User enters "A" back again in the input (NOTE: re-entering any value other than "A", which was previously entered, will not reproduce the problem) 4. Users hits ENTER 4. onchange event is not fired What is the expected behavior? As other browsers behave (including Safari, Firefox, and IE), the onchange event should be fired even if the user re-enters a previous value. What went wrong? The onchange event is not fired when the user re-inputs the previously entered value with ENTER key. Attached is a simple my-input.html which reproduced the problem with 2 types of inputs. Did this work before? N/A Chrome version: 56.0.2924.87 Channel: stable OS Version: OS X 10.12.3 Flash Version:
,
Mar 13 2017
Issue 700841 has been merged into this issue.
,
Mar 13 2017
,
Mar 14 2017
Confirmed. This must be a regression since Google Chrome 56.
,
Mar 14 2017
,
Mar 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1eff0d16f548ffa09d45de590c17f780406ae05e commit 1eff0d16f548ffa09d45de590c17f780406ae05e Author: tkent <tkent@chromium.org> Date: Tue Mar 14 07:03:53 2017 INPUT element: Implicit form submission should reset setTextAsOfLastFormControlChangeEvent even if no <form>. BUG= 700842 Review-Url: https://codereview.chromium.org/2749513003 Cr-Commit-Position: refs/heads/master@{#456644} [modify] https://crrev.com/1eff0d16f548ffa09d45de590c17f780406ae05e/third_party/WebKit/LayoutTests/fast/forms/text/text-change-event-after-clear-in-submit.html [modify] https://crrev.com/1eff0d16f548ffa09d45de590c17f780406ae05e/third_party/WebKit/Source/core/html/HTMLInputElement.cpp
,
Mar 14 2017
,
Mar 15 2017
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 15 2017
Your change is approved for M58. Please ensure whether this fix is verified in canary. If yes, please merge ASAP so that it will be picked up for M58 Beta promotion RC cut today(Wednesday - 03/15) at 5.00 PM PST.
,
Mar 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/16f569908242d83a4b549ff754ead68f39e339a0 commit 16f569908242d83a4b549ff754ead68f39e339a0 Author: Kent Tamura <tkent@chromium.org> Date: Wed Mar 15 22:54:54 2017 Merge "INPUT element: Implicit form submission should reset setTextAsOfLastFormControlChangeEvent even if no <form>." to M58 BUG= 700842 Review-Url: https://codereview.chromium.org/2749513003 Cr-Commit-Position: refs/heads/master@{#456644} (cherry picked from commit 1eff0d16f548ffa09d45de590c17f780406ae05e) Review-Url: https://codereview.chromium.org/2756483005 . Cr-Commit-Position: refs/branch-heads/3029@{#220} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} [modify] https://crrev.com/16f569908242d83a4b549ff754ead68f39e339a0/third_party/WebKit/LayoutTests/fast/forms/text/text-change-event-after-clear-in-submit.html [modify] https://crrev.com/16f569908242d83a4b549ff754ead68f39e339a0/third_party/WebKit/Source/core/html/HTMLInputElement.cpp
,
Mar 17 2017
Tested the issue on Mac 10.12.3 using chrome dev version#59.0.3043.0 with the steps mentioned in comment #0.Observed that the onchange event got fired even if the user re-enters a previous value.Hence adding TE-Verified labels. Please find the attached screen cast for the same. Thanks!!
,
Mar 22 2017
Tested the issue on Mac 10.12.3 using chrome version 58.0.3029.33.Observed that onchange event fired if we re-inputs the previously entered value with ENTER key.Please find the attached screen cast for the same. Adding TE-Verified labels. Thanks, |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by jammoul....@gmail.com
, Mar 13 2017