New issue
Advanced search Search tips

Issue 700830 link

Starred by 1 user
Status: Fixed
Owner:
drott@chromium.org
Closed: Mar 2017
Cc:
behdad@chromium.org
bunge...@chromium.org
e...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug

Blocking:
issue 669453



Sign in to add a comment

Prepare unified FreeType checkout for building on Windows

Project Member Reported by drott@chromium.org, Mar 13 2017 
In the demo we've built we used the previous freetype-android checkout, which had slightly different settings and approaches for managing visibility (a copy of ftconfig.h).

Let's get the new freetype checkout to work for Windows compilation and linkage as well.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/567ff79ca421beccab0b5babdeef3d6d9b89b9ea

commit 567ff79ca421beccab0b5babdeef3d6d9b89b9ea
Author: drott <drott@chromium.org>
Date: Mon Mar 13 15:55:43 2017

Manage FreeType symbol visibility using platform specific FT_EXPORT

MSVC does not support the -fvisibility-* option, hence providing
platform specific macros for library export visibility. Also,
suppress unused function warnings on non-Windows platforms only.

BUG= 700830 

Review-Url: https://codereview.chromium.org/2738383002
Cr-Commit-Position: refs/heads/master@{#456390}

[modify] https://crrev.com/567ff79ca421beccab0b5babdeef3d6d9b89b9ea/third_party/freetype/BUILD.gn
[modify] https://crrev.com/567ff79ca421beccab0b5babdeef3d6d9b89b9ea/third_party/freetype/include/freetype-custom-config/ftoption.h

Comment 2 by drott@chromium.org, Mar 13 2017

Status: Fixed (was: Started)
►

Sign in to add a comment