Re enable HistoryEntryInserterTest.AddSections |
||||||
Issue descriptionHistoryEntryInserterTest.AddSections was disabled because it was consistently failing.
,
Mar 13 2017
,
Mar 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e46508c00a4e04d5456dcecafbf7d2f38123040a commit e46508c00a4e04d5456dcecafbf7d2f38123040a Author: gambard <gambard@chromium.org> Date: Mon Mar 13 09:43:24 2017 Disable HistoryEntryInserterTest.AddSection unit test Failing consistently BUG= 700814 TBR=lpromero@chromium.org Review-Url: https://codereview.chromium.org/2746893002 Cr-Commit-Position: refs/heads/master@{#456344} [modify] https://crrev.com/e46508c00a4e04d5456dcecafbf7d2f38123040a/ios/chrome/browser/ui/history/history_entry_inserter_unittest.mm
,
Mar 13 2017
,
Mar 13 2017
If it is time-based it might break the beta/stable builders.
,
Mar 13 2017
Issue 666816 has been merged into this issue.
,
Mar 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/88543c5651a7509cf1d39370504a597081b240e9 commit 88543c5651a7509cf1d39370504a597081b240e9 Author: lpromero <lpromero@chromium.org> Date: Mon Mar 13 12:44:21 2017 Reenable HistoryEntryInserterTest.AddSections. The test added history entries at 1am the day of the test, the day before and 2 days before and expects the three to appear in different sections. With DST, 48hours before was still the same day as 24h ago. This test would have turned green tomorrow, but now that it is moved to middays, we shouldn't run in the issue again next time. BUG= 700814 R=gambard@chromium.org Review-Url: https://codereview.chromium.org/2747713002 Cr-Commit-Position: refs/heads/master@{#456356} [modify] https://crrev.com/88543c5651a7509cf1d39370504a597081b240e9/ios/chrome/browser/ui/history/history_entry_inserter_unittest.mm
,
Mar 13 2017
,
Mar 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/973aa79155460a0ff6e7c36452ab18dd9c4ec960 commit 973aa79155460a0ff6e7c36452ab18dd9c4ec960 Author: lpromero <lpromero@chromium.org> Date: Mon Mar 13 18:27:58 2017 Fix FirstRunTestCase.testTermsAndConditions on official The test expected Chromium branded, which failed on Official builds. BUG= 700814 R=kkhorimoto@chromium.org TBR=gambard@chromium.org Review-Url: https://codereview.chromium.org/2745123002 Cr-Commit-Position: refs/heads/master@{#456437} [modify] https://crrev.com/973aa79155460a0ff6e7c36452ab18dd9c4ec960/ios/chrome/browser/ui/first_run/first_run_egtest.mm
,
May 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/08a3880775332befb1c8876e0badf755ea04aac8 commit 08a3880775332befb1c8876e0badf755ea04aac8 Author: Kurt Horimoto <kkhorimoto@chromium.org> Date: Fri May 19 18:04:08 2017 Fix FirstRunTestCase.testTermsAndConditions on official The test expected Chromium branded, which failed on Official builds. BUG= 700814 R=kkhorimoto@chromium.org TBR=gambard@chromium.org Review-Url: https://codereview.chromium.org/2745123002 Cr-Original-Commit-Position: refs/heads/master@{#456437} Review-Url: https://codereview.chromium.org/2888383004 . Cr-Commit-Position: refs/branch-heads/3029@{#856} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} [modify] https://crrev.com/08a3880775332befb1c8876e0badf755ea04aac8/ios/chrome/browser/ui/first_run/first_run_egtest.mm |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by gambard@chromium.org
, Mar 13 2017