New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 700814 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
No longer actively working on Chrom...
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

Re enable HistoryEntryInserterTest.AddSections

Project Member Reported by gambard@chromium.org, Mar 13 2017

Issue description

HistoryEntryInserterTest.AddSections was disabled because it was consistently failing.
 
It started failing at midnight, it might be related to time zone change (light saving time).
Owner: lpromero@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e46508c00a4e04d5456dcecafbf7d2f38123040a

commit e46508c00a4e04d5456dcecafbf7d2f38123040a
Author: gambard <gambard@chromium.org>
Date: Mon Mar 13 09:43:24 2017

Disable HistoryEntryInserterTest.AddSection unit test

Failing consistently

BUG= 700814 
TBR=lpromero@chromium.org

Review-Url: https://codereview.chromium.org/2746893002
Cr-Commit-Position: refs/heads/master@{#456344}

[modify] https://crrev.com/e46508c00a4e04d5456dcecafbf7d2f38123040a/ios/chrome/browser/ui/history/history_entry_inserter_unittest.mm

Labels: -Pri-3 M-59 ReleaseBlock-Beta Pri-2
If it is time-based it might break the beta/stable builders.
Cc: anthonyvd@chromium.org rohitrao@chromium.org marq@chromium.org stkhapugin@chromium.org lpromero@chromium.org
 Issue 666816  has been merged into this issue.
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/88543c5651a7509cf1d39370504a597081b240e9

commit 88543c5651a7509cf1d39370504a597081b240e9
Author: lpromero <lpromero@chromium.org>
Date: Mon Mar 13 12:44:21 2017

Reenable HistoryEntryInserterTest.AddSections.

The test added history entries at 1am the day of the test, the day before and 2 days before and expects the three to appear in different sections.
With DST, 48hours before was still the same day as 24h ago.
This test would have turned green tomorrow, but now that it is moved to middays, we shouldn't run in the issue again next time.

BUG= 700814 
R=gambard@chromium.org

Review-Url: https://codereview.chromium.org/2747713002
Cr-Commit-Position: refs/heads/master@{#456356}

[modify] https://crrev.com/88543c5651a7509cf1d39370504a597081b240e9/ios/chrome/browser/ui/history/history_entry_inserter_unittest.mm

Status: Fixed (was: Assigned)
Project Member

Comment 9 by bugdroid1@chromium.org, Mar 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/973aa79155460a0ff6e7c36452ab18dd9c4ec960

commit 973aa79155460a0ff6e7c36452ab18dd9c4ec960
Author: lpromero <lpromero@chromium.org>
Date: Mon Mar 13 18:27:58 2017

Fix FirstRunTestCase.testTermsAndConditions on official

The test expected Chromium branded, which failed on Official builds.

BUG= 700814 
R=kkhorimoto@chromium.org
TBR=gambard@chromium.org

Review-Url: https://codereview.chromium.org/2745123002
Cr-Commit-Position: refs/heads/master@{#456437}

[modify] https://crrev.com/973aa79155460a0ff6e7c36452ab18dd9c4ec960/ios/chrome/browser/ui/first_run/first_run_egtest.mm

Project Member

Comment 10 by bugdroid1@chromium.org, May 19 2017

Labels: merge-merged-3029
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/08a3880775332befb1c8876e0badf755ea04aac8

commit 08a3880775332befb1c8876e0badf755ea04aac8
Author: Kurt Horimoto <kkhorimoto@chromium.org>
Date: Fri May 19 18:04:08 2017

Fix FirstRunTestCase.testTermsAndConditions on official

The test expected Chromium branded, which failed on Official builds.

BUG= 700814 
R=kkhorimoto@chromium.org
TBR=gambard@chromium.org

Review-Url: https://codereview.chromium.org/2745123002
Cr-Original-Commit-Position: refs/heads/master@{#456437}
Review-Url: https://codereview.chromium.org/2888383004 .
Cr-Commit-Position: refs/branch-heads/3029@{#856}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/08a3880775332befb1c8876e0badf755ea04aac8/ios/chrome/browser/ui/first_run/first_run_egtest.mm

Sign in to add a comment