Disable autofill for Credit Card Information by policy
Reported by
pas...@flint-it.com,
Mar 13 2017
|
|||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 6.3; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2924.87 Safari/537.36 Steps to reproduce the problem: 1. Install Chrome in a multi-user Windows domain environment. 2. Attempt to deploy policy to disable auto-fill for credit card information on Chrome across the domain without disabling auto-fill as a whole. What is the expected behavior? There seem to be 3 options to disable this in the experimental settings in chrome://flags, but you should be able to disable this by registry changes, administrative templates and/or a built-in non-experimental Chrome setting. What went wrong? Attempts to deploy or find a way of deplying were on the whole highly unsuccessful. Using file/registry monitor applications to check what was changed before & after the settings changes were unable to isolate the change made by this experimental setting. Would be great to see this rolled into future Chrome versions by the Chrome team. Did this work before? No Chrome version: 56.0.2924.87 Channel: stable OS Version: 6.3 Flash Version: N/A Was requested to post this here on the Enterprise help forums: https://productforums.google.com/forum/#!topic/chrome-admins/Xs6R2kD-tes;context-place=forum/chrome-admins
,
Mar 15 2017
,
Mar 15 2017
Autofill is supported by policy. https://www.chromium.org/administrators/policy-list-3#AutoFillEnabled Breaking this piece out into a new policy specifically for credit-card autofill controls is something will investigate. Lowering priority to P3 for now.
,
Mar 16 2017
,
Mar 21 2017
Gentle Ping... georgesak@ could you please provide the latest update on this issue. Thank You...
,
Mar 21 2017
As per https://www.chromium.org/developers/how-tos/enterprise/adding-new-policies, we need to have the functionality wired to a pref first, then we can add the policy. Currently, there's no pref to control just the payment part of autofill and AFAIK, there's no timeline to get one currently. +rogerm who can chime in on whether we should add that pref.
,
Mar 27 2017
Adding the milestone as this is in assigned status. Please adjust the milestone as appropriate.
,
Apr 12 2017
Changing to M-60 and assigning to fdoray@.
,
May 2 2017
,
May 10 2017
,
Sep 13 2017
,
Sep 13 2017
,
Oct 2 2017
We need this for policy - since we have computers that the public uses and it does not need to store the cc information for us to be compliant. Would like to see that when autofill is disable as per GPO - users can not store CC info or address info if autofill is disabled.
,
Oct 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/af4f033c8da7ddb29a9a73ce6b4f78f218f11b88 commit af4f033c8da7ddb29a9a73ce6b4f78f218f11b88 Author: Cait Phillips <caitkp@chromium.org> Date: Fri Oct 06 00:40:22 2017 Add a pref to disable autofill credit cards so we can control it by policy. Bug: 700812 Change-Id: I4ab2534057debd0d1c94b20e6c8b8844fd364d87 Reviewed-on: https://chromium-review.googlesource.com/666059 Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by: Roger McFarlane <rogerm@chromium.org> Reviewed-by: Jesse Doherty <jwd@chromium.org> Commit-Queue: Roger McFarlane <rogerm@chromium.org> Commit-Queue: Cait Phillips <caitkp@chromium.org> Cr-Commit-Position: refs/heads/master@{#506929} [modify] https://crrev.com/af4f033c8da7ddb29a9a73ce6b4f78f218f11b88/chrome/browser/policy/configuration_policy_handler_list_factory.cc [modify] https://crrev.com/af4f033c8da7ddb29a9a73ce6b4f78f218f11b88/chrome/test/data/policy/policy_test_cases.json [modify] https://crrev.com/af4f033c8da7ddb29a9a73ce6b4f78f218f11b88/components/autofill/core/browser/autofill_manager.cc [modify] https://crrev.com/af4f033c8da7ddb29a9a73ce6b4f78f218f11b88/components/autofill/core/browser/autofill_manager.h [modify] https://crrev.com/af4f033c8da7ddb29a9a73ce6b4f78f218f11b88/components/autofill/core/browser/autofill_manager_unittest.cc [modify] https://crrev.com/af4f033c8da7ddb29a9a73ce6b4f78f218f11b88/components/autofill/core/browser/autofill_merge_unittest.cc [modify] https://crrev.com/af4f033c8da7ddb29a9a73ce6b4f78f218f11b88/components/autofill/core/browser/personal_data_manager.cc [modify] https://crrev.com/af4f033c8da7ddb29a9a73ce6b4f78f218f11b88/components/autofill/core/browser/personal_data_manager.h [modify] https://crrev.com/af4f033c8da7ddb29a9a73ce6b4f78f218f11b88/components/autofill/core/browser/personal_data_manager_unittest.cc [modify] https://crrev.com/af4f033c8da7ddb29a9a73ce6b4f78f218f11b88/components/autofill/core/common/autofill_pref_names.cc [modify] https://crrev.com/af4f033c8da7ddb29a9a73ce6b4f78f218f11b88/components/autofill/core/common/autofill_pref_names.h [modify] https://crrev.com/af4f033c8da7ddb29a9a73ce6b4f78f218f11b88/components/browser_sync/profile_sync_service_autofill_unittest.cc [modify] https://crrev.com/af4f033c8da7ddb29a9a73ce6b4f78f218f11b88/components/policy/core/browser/BUILD.gn [add] https://crrev.com/af4f033c8da7ddb29a9a73ce6b4f78f218f11b88/components/policy/core/browser/autofill_credit_card_policy_handler.cc [add] https://crrev.com/af4f033c8da7ddb29a9a73ce6b4f78f218f11b88/components/policy/core/browser/autofill_credit_card_policy_handler.h [add] https://crrev.com/af4f033c8da7ddb29a9a73ce6b4f78f218f11b88/components/policy/core/browser/autofill_credit_card_policy_handler_unittest.cc [modify] https://crrev.com/af4f033c8da7ddb29a9a73ce6b4f78f218f11b88/components/policy/resources/policy_templates.json [modify] https://crrev.com/af4f033c8da7ddb29a9a73ce6b4f78f218f11b88/tools/metrics/histograms/enums.xml
,
Oct 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2a74f8181a5bd238a0d8d0e4c864a716b5838acd commit 2a74f8181a5bd238a0d8d0e4c864a716b5838acd Author: Cait Phillips <caitkp@chromium.org> Date: Wed Oct 18 15:58:49 2017 Test that credit cards stay disabled when PersonalData is reset. Bug: 700812 Change-Id: Id1b5809768abfa25f83df36d80e498837e4a6c01 Reviewed-on: https://chromium-review.googlesource.com/716844 Commit-Queue: Cait Phillips <caitkp@chromium.org> Reviewed-by: Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#509781} [modify] https://crrev.com/2a74f8181a5bd238a0d8d0e4c864a716b5838acd/components/autofill/core/browser/personal_data_manager.h [modify] https://crrev.com/2a74f8181a5bd238a0d8d0e4c864a716b5838acd/components/autofill/core/browser/personal_data_manager_unittest.cc
,
Oct 26 2017
String (no punctuation): "Saved cards are disabled by your administrator" icon: iron-icon, id=indicator icon color: paper-grey 600 icon size: 20x20px *Remove the ADD button from 'Credit cards' Please just ping me with a screenshot of your implementation when ready. No need to assign me the bug given the size of the change. Thanks!
,
Nov 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/13bcf2bcf14009fcdd4fce2099effa1ac08ec431 commit 13bcf2bcf14009fcdd4fce2099effa1ac08ec431 Author: Cait Phillips <caitkp@chromium.org> Date: Wed Nov 08 00:01:56 2017 Disable Sync for Wallet if credit card autofill is disabled by policy This is a follow up CL to https://chromium-review.googlesource.com/c/chromium/src/+/666059, which ensures that no credit card data is synced if autofill for credit cards has been disabled by policy. Bug: 700812 Change-Id: Ie458e9fdc4ee52308b23b862cedb531bdeb2fb22 Reviewed-on: https://chromium-review.googlesource.com/703398 Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by: Nicolas Zea <zea@chromium.org> Reviewed-by: Roger McFarlane <rogerm@chromium.org> Commit-Queue: Cait Phillips <caitkp@chromium.org> Cr-Commit-Position: refs/heads/master@{#514663} [modify] https://crrev.com/13bcf2bcf14009fcdd4fce2099effa1ac08ec431/chrome/browser/policy/configuration_policy_handler_list_factory.cc [modify] https://crrev.com/13bcf2bcf14009fcdd4fce2099effa1ac08ec431/components/autofill/core/browser/BUILD.gn [modify] https://crrev.com/13bcf2bcf14009fcdd4fce2099effa1ac08ec431/components/autofill/core/browser/DEPS [rename] https://crrev.com/13bcf2bcf14009fcdd4fce2099effa1ac08ec431/components/autofill/core/browser/autofill_credit_card_policy_handler.cc [add] https://crrev.com/13bcf2bcf14009fcdd4fce2099effa1ac08ec431/components/autofill/core/browser/autofill_credit_card_policy_handler.h [rename] https://crrev.com/13bcf2bcf14009fcdd4fce2099effa1ac08ec431/components/autofill/core/browser/autofill_credit_card_policy_handler_unittest.cc [rename] https://crrev.com/13bcf2bcf14009fcdd4fce2099effa1ac08ec431/components/autofill/core/browser/autofill_policy_handler.cc [rename] https://crrev.com/13bcf2bcf14009fcdd4fce2099effa1ac08ec431/components/autofill/core/browser/autofill_policy_handler.h [rename] https://crrev.com/13bcf2bcf14009fcdd4fce2099effa1ac08ec431/components/autofill/core/browser/autofill_policy_handler_unittest.cc [modify] https://crrev.com/13bcf2bcf14009fcdd4fce2099effa1ac08ec431/components/autofill/core/browser/autofill_wallet_data_type_controller.cc [add] https://crrev.com/13bcf2bcf14009fcdd4fce2099effa1ac08ec431/components/autofill/core/browser/autofill_wallet_data_type_controller_unittest.cc [modify] https://crrev.com/13bcf2bcf14009fcdd4fce2099effa1ac08ec431/components/policy/core/browser/BUILD.gn [modify] https://crrev.com/13bcf2bcf14009fcdd4fce2099effa1ac08ec431/components/policy/core/browser/DEPS [delete] https://crrev.com/cf27dae13b5876434e1d8061596316927d89a4e5/components/policy/core/browser/autofill_credit_card_policy_handler.h
,
Nov 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2049b868fe68d233c7b1ba4455689e156ab302b9 commit 2049b868fe68d233c7b1ba4455689e156ab302b9 Author: Cait Phillips <caitkp@chromium.org> Date: Sat Nov 18 00:28:00 2017 Hide Autofill credit card data if disabled by policy Bug: 700812 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ib3d0a17e24b6b3c08e34de68400c0a1fe3a855f4 Reviewed-on: https://chromium-review.googlesource.com/761239 Commit-Queue: Cait Phillips <caitkp@chromium.org> Reviewed-by: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#517631} [modify] https://crrev.com/2049b868fe68d233c7b1ba4455689e156ab302b9/chrome/app/settings_strings.grdp [modify] https://crrev.com/2049b868fe68d233c7b1ba4455689e156ab302b9/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html [modify] https://crrev.com/2049b868fe68d233c7b1ba4455689e156ab302b9/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.js [modify] https://crrev.com/2049b868fe68d233c7b1ba4455689e156ab302b9/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc [modify] https://crrev.com/2049b868fe68d233c7b1ba4455689e156ab302b9/chrome/test/data/webui/settings/passwords_and_forms_browsertest.js [modify] https://crrev.com/2049b868fe68d233c7b1ba4455689e156ab302b9/chrome/test/data/webui/settings/settings_autofill_section_browsertest.js
,
Nov 29 2017
,
Nov 29 2017
Hooray! Thanks all for the hard work. Which version can we expect this to be rolled into and when is its E.T.A release date?
,
Nov 29 2017
This feature will be part of the M64 release which is set to go to the Stable channel on Jan 23 2018.
,
Jan 24 2018
Any estimate as to when this will be rolled out in the stable Chrome releases? (as opposed to Chromium)
,
Jan 24 2018
See Comment #22. Any day now :)
,
Feb 22 2018
Not sure if I'm just being impatient or if I'm missing something, but the feature doesn't appear to be here yet in my latest 64.0.3282.167...? Is it perhaps in the group policies and appears only after disabling by policy, or should I expect the option to be available from an end-user perspective too?
,
Feb 22 2018
@27 This is a policy and not a setting. Hence why you don't see it there. There's no UI to set it. This needs to be pushed to devices, through whatever mechanism you have for managing those devices (ex. GPOs on Windows).
,
Mar 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e060d6fc6513035444eda65338021e1247b65c0e commit e060d6fc6513035444eda65338021e1247b65c0e Author: Cait Phillips <caitkp@chromium.org> Date: Fri Mar 02 14:38:31 2018 Whitelist AutofillCreditCardEnabled pref for enterprise policy. This should have landed with https://chromium-review.googlesource.com/c/chromium/src/+/761239 and fixes an isssue where users can add new credit cards in Settings/Autofill even if credit cards are disabled. Bug: 700812 Change-Id: Iccd242ae2f5aef910081199dbbf1a67328953b63 Reviewed-on: https://chromium-review.googlesource.com/944505 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Cait Phillips <caitkp@chromium.org> Cr-Commit-Position: refs/heads/master@{#540514} [modify] https://crrev.com/e060d6fc6513035444eda65338021e1247b65c0e/chrome/browser/extensions/api/settings_private/prefs_util.cc
,
Mar 14 2018
Hi guys, Makes sense - I was keeping an eye on the GUI because I was under the impression it was getting implemented as both a policy as well as a UI changeable setting. In any case policy only suits our purposes perfectly. Deployed out GPO to a pilot group of ~20 users yesterday and will likely look at getting it deployed to the whole organization if all goes well over the next few weeks. Thanks for your help on this all! Kind regards, Pascal
,
Mar 14 2018
|
|||||||||||||
►
Sign in to add a comment |
|||||||||||||
Comment 1 by pastarmovj@chromium.org
, Mar 13 2017Owner: blumberg@chromium.org