New issue
Advanced search Search tips

Issue 700811 link

Starred by 0 users
Status: Fixed
Owner:
mastiz@chromium.org
Closed: May 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 694312



Sign in to add a comment

Verify content of bitmaps in FaviconHandler tests

Project Member Reported by mastiz@chromium.org, Mar 13 2017 
It would be nice if in certain FaviconHandler tests, e.g. RedownloadExpiredFavicon, we could check whether the two OnFaviconUpdated() calls are called with different gfx::Images (as opposed to calling OnFaviconUpdated() with the expired gfx::Image both times).

Comment 1 by mastiz@chromium.org, Mar 13 2017 

From another comment by pkotwicz@, wrt to FaviconInHistoryInvalid:
"This would be a good test to check the color of the gfx::Image parameter. You
can't truly test that the invalid data is not sent in the UI without checking
the gfx::Image parameter. I believe that in a different comment your requested
to do this as part of a separate CL"
Project Member

Comment 2 by bugdroid1@chromium.org, May 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5730d628131f2ac3cd4a9a834a3fe812cc570ade

commit 5730d628131f2ac3cd4a9a834a3fe812cc570ade
Author: mastiz <mastiz@chromium.org>
Date: Wed May 10 05:42:54 2017

Verify favicon bitmap content in FaviconHandler tests

Follow up to the test refactoring series in  crbug.com/694312 , addressing
two TODOs about verifying the actual content of the bitmaps, which is
done based on the color of one arbitrary pixel.

BUG= 700811 

Review-Url: https://codereview.chromium.org/2872643002
Cr-Commit-Position: refs/heads/master@{#470489}

[modify] https://crrev.com/5730d628131f2ac3cd4a9a834a3fe812cc570ade/components/favicon/core/favicon_handler_unittest.cc

Comment 3 by mastiz@chromium.org, May 10 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment