New issue
Advanced search Search tips

Issue 700809 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

setup.exe --uninstall leaves files behind when TMP is on a different volume

Project Member Reported by grt@chromium.org, Mar 13 2017

Issue description

To repro:
- install Chrome in a usual place
- set TMP to some dir on a different volume from %LOCALAPPDATA%/%PROGRAMFILES(X86)%
- uninstall Chrome

some files are left behind.

This is happening because setup.exe tries to MoveFileEx itself into TMP so that the Chrome app tree can be deleted. It then jumps through hoops to delete itself from TMP. We should do better to handle this case. Perhaps the files can be painted with delete-on-close if the move fails? Perhaps the cleanup job (which deletes the file from TMP) can be given the job of deleting the original files (be careful, though, we don't want to delete files put into place because of a reinstall!). Perhaps the files should be moved up a few layers in the directory tree into a dir that we name "Temp" and then deleted from the other proc? Many possiblities.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d67a4a2ec000954c8b66216a3d2952f802be4d72

commit d67a4a2ec000954c8b66216a3d2952f802be4d72
Author: Greg Thompson <grt@chromium.org>
Date: Wed Aug 02 09:06:26 2017

Force TMP to a directory on the same volume as "Program Files (x86)".

This is a workaround to https://crbug.com/700809.

BUG=700809, 745825 

Change-Id: Ifba9aef86b8218a97d4f5abe1b979fb0305562ab
Reviewed-on: https://chromium-review.googlesource.com/589168
Reviewed-by: Daniel Jacques <dnj@chromium.org>
Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491319}
[modify] https://crrev.com/d67a4a2ec000954c8b66216a3d2952f802be4d72/chrome/test/mini_installer/test_installer.py

Project Member

Comment 2 by sheriffbot@chromium.org, Aug 2

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Pri-2 Pri-3
Status: Available (was: Untriaged)

Sign in to add a comment