New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 700797 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Warning symbol is missing near Network Tab of Devtools.

Project Member Reported by ratnavar...@techmahindra.com, Mar 13 2017

Issue description

Chrome Version:58.0.3040.0 dev
OS:Ubuntu 14.04,Windows

What steps will reproduce the problem?
(1)Launch Chrome, open Devtools and goto Network tab.
(2)Check the Offline button and Observe

Actual Result: Warning symbol is missing near Network Tab when checked offline.
Expected Result: Warning symbol should be seen near Network Tab when checked offline.

Note: Issue is seen in performance and network conditions tab as well.

This is a Regression issue broken in M-59

Manual Bisect Info
==================
Good Build:59.0.3037.0
Bad Build :59.0.3038.0


 
Actual.png
153 KB View Download
Expected.png
153 KB View Download
Labels: OS-Mac
Status: Untriaged (was: Unconfirmed)
Able to reproduce this issue on Mac OS 10.12 using chrome latest canary #59.0.3039.0. 

Comment 2 by ajha@chromium.org, Mar 13 2017

Components: -Platform>DevTools Platform>DevTools>Network
Owner: allada@chromium.org
Status: Assigned (was: Untriaged)
Bisect is not working on Mac due to  Issue 700097 , hence unable to provide the bisect. Will provide the hasbisect per revision when have access to Windows or Linux system with the bisect set up.

Manually inspecting the changelog: https://chromium.googlesource.com/chromium/src/+log/59.0.3037.0..59.0.3038.0?pretty=fuller&n=10000

allada@: Could this be related to https://codereview.chromium.org/2731633002 or https://codereview.chromium.org/2692653003.

Please re-assign if the changes are unrelated.

Comment 3 by ajha@chromium.org, Mar 14 2017

Labels: -Needs-Bisect hasbisect-per-revision
Ran has bisect per revision and this indeed points to https://codereview.chromium.org/2692653003.

Comment 4 by ja...@apphaus.co.uk, Mar 20 2017

I hope I'm not stepping on other's toes, as I know this issue has been assigned. Curiosity took over and I have shared my findings in the form of a CL to Code Review (https://codereview.chromium.org/2758183002).
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/33bc6b04dccef0bc2c1066dad202474e35e6dda7

commit 33bc6b04dccef0bc2c1066dad202474e35e6dda7
Author: james <james@apphaus.co.uk>
Date: Tue Mar 21 00:49:03 2017

DevTools: Fix Network panel warning icon display when offline/throttled

Fixes an issue whereby the warning icon on the tab for the Network panel would not appear when offline or the network was otherwised throttled.

This issue was a regression in https://codereview.chromium.org/2692653003.

The fix works in the Network panel and Performance panel when offline/throttling is changed.

The following issue  http://crbug.com/702070  prevents the warning icon from being displayed when emulating offline from the Service Workers pane within the Applications panel. https://codereview.chromium.org/2757093002 should fix this.

BUG= 700797 

Review-Url: https://codereview.chromium.org/2758183002
Cr-Commit-Position: refs/heads/master@{#458260}

[modify] https://crrev.com/33bc6b04dccef0bc2c1066dad202474e35e6dda7/AUTHORS
[modify] https://crrev.com/33bc6b04dccef0bc2c1066dad202474e35e6dda7/third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js

Labels: TE-Verified-59.0.3053.3 TE-Verified-M59
Tested the issue on Latest Dev# 59.0.3053.3 on Windows, Mac and Linux and found the issue to be fixed.
Observed the warning symbol adjacent to Network tab.
Hence adding TE-Verified Labels.
Note: Attaching a screenshot for reference.
Thank You.

Comment 8 by allada@chromium.org, Jul 20 2017

Status: Fixed (was: Assigned)

Sign in to add a comment