New issue
Advanced search Search tips

Issue 700782 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

jpeg_decode_accelerator_unittest shouldn't require the test file in /media/test/data/

Project Member Reported by wuchengli@chromium.org, Mar 13 2017

Issue description

Chrome OS: elm 9349.0.0 with chrome synced on Jan 18

What steps will reproduce the problem?
(1) Build jpeg_decode_accelerator_unittest.
(2) Copy the test binary and media/test/data/peach_pi-1280x720.jpg to /home in DUT.
(3) Run ./jpeg_decode_accelerator_unittest --jpeg_filenames=./peach_pi-1280x720.jpg on DUT.

What is the expected result?
The test should pass.

What happens instead?
The test complained the test jpeg didn't exist. The test expected the jpeg to be in /media/test/data.


 
Cc: johnylin@chromium.org
Johny is also looking at a related issue for VDA or VEA unittest.

For VDA unittest, it's ok for test videos and test binary to be at the same folder.
Cc: henryhsu@chromium.org
Owner: mojahsu@chromium.org
Labels: -videoshortlist
Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dc3a1ab1e79d4d5dced497aaabd8aab9cbabcd67

commit dc3a1ab1e79d4d5dced497aaabd8aab9cbabcd67
Author: mojahsu <mojahsu@chromium.org>
Date: Thu Jun 15 11:58:23 2017

JDA unittest: don't require the test file in /media/test/data/.

The test expected the jpeg to be in /media/test/data. Let it can get
jpeg file from both original file path or under /media/test/data path.

BUG= 700782 
TEST=Run JDA unittest on elm with test file in local directory or
/media/test/data directory.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2922323003
Cr-Commit-Position: refs/heads/master@{#479671}

[modify] https://crrev.com/dc3a1ab1e79d4d5dced497aaabd8aab9cbabcd67/media/gpu/jpeg_decode_accelerator_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment