New issue
Advanced search Search tips

Issue 700777 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Log DSE geolocation stats

Project Member Reported by benwells@chromium.org, Mar 13 2017

Issue description

We have metrics being logged for the geolocation content setting for the user's search engine, but not the dse geolocation setting.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5754a56b61f227091f272bc84bfb212b9ba78416

commit 5754a56b61f227091f272bc84bfb212b9ba78416
Author: benwells <benwells@chromium.org>
Date: Mon Apr 10 09:42:02 2017

Log metrics for the new Default Search Engine geolocation setting.

Recently a new system was introduced which added a preference for
whether the default search engine has geolocation access or not. This
change adds metrics for the state of this setting before the disclosure
UI is shown and after the disclosure UI is shown for the last time.

BUG= 700777 

Review-Url: https://codereview.chromium.org/2793253002
Cr-Commit-Position: refs/heads/master@{#463204}

[modify] https://crrev.com/5754a56b61f227091f272bc84bfb212b9ba78416/chrome/android/javatests/src/org/chromium/chrome/browser/infobar/SearchGeolocationDisclosureInfoBarTest.java
[modify] https://crrev.com/5754a56b61f227091f272bc84bfb212b9ba78416/chrome/browser/android/search_geolocation/search_geolocation_disclosure_tab_helper.cc
[modify] https://crrev.com/5754a56b61f227091f272bc84bfb212b9ba78416/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Assigned)

Sign in to add a comment