Password bubble jumps to the left |
|||||||||
Issue descriptionApp Version (from "Chrome Settings > About Chrome"): 59.0.3037.1 Windows Version: w10 Take a look at this video: https://drive.google.com/open?id=0B3dPCXKQYa2dR0NGZG1KeXdHeUk Screenshot of the occurrence: https://drive.google.com/open?id=0B3dPCXKQYa2dYXNfNU9seXZoazQ As the password bubble disappears, it jumps to the left before resizing. Can we smooth out the transition by having the bubble grow to the left?
,
Mar 14 2017
,
Apr 3 2017
,
Apr 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/218d4bbf6ae8e118ee2bd86a9b1761786ccd13b9 commit 218d4bbf6ae8e118ee2bd86a9b1761786ccd13b9 Author: mrefaat <mrefaat@chromium.org> Date: Tue Apr 18 22:26:32 2017 Update the Windows iOS promotion so it has the same width as the bubble that appears before it. This is needed as pre-harmony because there is no fixed width for all bubbles. BUG= 700759 Review-Url: https://codereview.chromium.org/2815303004 Cr-Commit-Position: refs/heads/master@{#465398} [modify] https://crrev.com/218d4bbf6ae8e118ee2bd86a9b1761786ccd13b9/chrome/app/resources/locale_settings.grd [modify] https://crrev.com/218d4bbf6ae8e118ee2bd86a9b1761786ccd13b9/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc [modify] https://crrev.com/218d4bbf6ae8e118ee2bd86a9b1761786ccd13b9/chrome/browser/ui/views/desktop_ios_promotion/desktop_ios_promotion_bubble_view.cc [modify] https://crrev.com/218d4bbf6ae8e118ee2bd86a9b1761786ccd13b9/chrome/browser/ui/views/desktop_ios_promotion/desktop_ios_promotion_bubble_view.h [modify] https://crrev.com/218d4bbf6ae8e118ee2bd86a9b1761786ccd13b9/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc
,
Apr 18 2017
,
Apr 19 2017
This bug requires manual review: There is .grd file changes and we are only 47 days from stable. Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 20 2017
Can you please confirm if this has been tested in canary, and if there is enough automated coverage?
,
Apr 21 2017
Yes it's tested on canary, and there is automated test for the bubble widget in: chrome/browser/ui/views/bookmarks/bookmark_bubble_view_browsertest.cc
,
Apr 21 2017
great, thanks - approving merge for M59 based on #8.
,
Apr 21 2017
Please merge your change to M59 branch #3071 latest before 4:00 PM PT, Monday (04/24) so we can take it for next week last M59 dev release. Thank you.
,
Apr 25 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 1 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 9 2017
Can you please merge this change to M59? This doesn't appear to be merged yet.
,
May 10 2017
cl https://codereview.chromium.org/2841713003/ was submitted 3 weeks ago for merge to 59.
,
May 10 2017
Tested this change on 59.0.3071.47, and it LGTM. mrefaat to verify
,
May 11 2017
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by jasonkliu@chromium.org
, Mar 12 2017