Issue metadata
Sign in to add a comment
|
Regression: The position of the Mr. Incognito Icon is broken when resizing the window |
||||||||||||||||||||||
Issue descriptionChrome Version: Version 59.0.3039.0 canary (64-bit) OS: MacOS 10.12.3 What steps will reproduce the problem? (1) Open an Incognito Window (2) Take a look at the Mr. Incognito Icon in the right upper corner in the Toolbar (3) Resize the window What is the expected result? What happens instead? The position of the icon is broken. Please use labels and text to provide additional information. This is a regression. A screencast is attached.
,
Mar 12 2017
I did a bisect. This is the regression range: https://chromium.googlesource.com/chromium/src/+log/9c3ce4099b593b5172fe94028c949730f72716ef..fa44a170953dea4680dc68f1eb0e145b97307958 avi@: It looks like your change https://codereview.chromium.org/2697293003 could be the culprit. Can you please take a look? Many thanks in advance.
,
Mar 12 2017
,
Mar 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9e4313b0e961f192ac53ede509ab9426f5065efc commit 9e4313b0e961f192ac53ede509ab9426f5065efc Author: avi <avi@chromium.org> Date: Mon Mar 13 17:44:20 2017 Properly pin the incognito avatar. BUG= 700741 Review-Url: https://codereview.chromium.org/2743393002 Cr-Commit-Position: refs/heads/master@{#456419} [modify] https://crrev.com/9e4313b0e961f192ac53ede509ab9426f5065efc/chrome/browser/ui/cocoa/browser_window_controller.mm [modify] https://crrev.com/9e4313b0e961f192ac53ede509ab9426f5065efc/chrome/browser/ui/cocoa/profiles/avatar_button_controller.mm
,
Mar 13 2017
,
Mar 14 2017
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), bhthompson@(cros), govind@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8b654db1bf9a3934aecc90466a68bd7d9c6213db commit 8b654db1bf9a3934aecc90466a68bd7d9c6213db Author: Avi Drissman <avi@chromium.org> Date: Tue Mar 14 20:28:24 2017 Properly pin the incognito avatar. BUG= 700741 Review-Url: https://codereview.chromium.org/2743393002 Cr-Commit-Position: refs/heads/master@{#456419} (cherry picked from commit 9e4313b0e961f192ac53ede509ab9426f5065efc) Review-Url: https://codereview.chromium.org/2753633002 . Cr-Commit-Position: refs/branch-heads/3029@{#195} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} [modify] https://crrev.com/8b654db1bf9a3934aecc90466a68bd7d9c6213db/chrome/browser/ui/cocoa/browser_window_controller.mm [modify] https://crrev.com/8b654db1bf9a3934aecc90466a68bd7d9c6213db/chrome/browser/ui/cocoa/profiles/avatar_button_controller.mm
,
Mar 14 2017
,
Mar 17 2017
Verified this issue on Mac 10.12.3 with chrome #59.0.3043.0 Observed Mr. Incognito Icon is fixed in the top right corner even after resizing the window Attaching the screen-cast for reference. Hence adding TE-Verified labels.
,
Mar 22 2017
Verified this issue on Mac 10.12.3 with chrome #58.0.3029.33 Observed Mr. Incognito Icon is fixed in the top right corner even after resizing the window Attaching the screen-cast for reference. Hence adding TE-Verified labels. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by meh...@chromium.org
, Mar 12 2017