New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 700696 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"ContinueWhereILeftOffTest.SessionCookies" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Mar 11 2017

Issue description

"ContinueWhereILeftOffTest.SessionCookies" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 4 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyMwsSBUZsYWtlIihDb250aW51ZVdoZXJlSUxlZnRPZmZUZXN0LlNlc3Npb25Db29raWVzDA.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/008c85e4011f9a860f94df75c3bd69c7aece6bab

commit 008c85e4011f9a860f94df75c3bd69c7aece6bab
Author: yoichio <yoichio@chromium.org>
Date: Tue Mar 14 09:33:04 2017

Disable flaky ContinueWhereILeftOffTest.SessionStorage/SessionCookies tests

They are flaky.

BUG= 700696 ,  700699 
TBR=sky@chromium.org

Review-Url: https://codereview.chromium.org/2750783002
Cr-Commit-Position: refs/heads/master@{#456659}

[modify] https://crrev.com/008c85e4011f9a860f94df75c3bd69c7aece6bab/chrome/browser/sessions/better_session_restore_browsertest.cc

Labels: -Sheriff-Chromium
Components: UI>Browser>Sessions
Owner: groby@chromium.org
groby@ - could you please help with triage and routing to the appropriate owner (I see that you own another similar bug - issue 656211)?
Cc: thomasanderson@chromium.org

Comment 5 by groby@chromium.org, May 15 2017

Cc: fdoray@chromium.org sky@chromium.org groby@chromium.org
Owner: ----
I really have no idea who could know. Like  bug #700699 , I'm not sure who's a good candidate

+sky for sessions/
+fdoray to see if  bug #717740  fix addresses this as well.

Comment 6 by fdoray@chromium.org, May 18 2017

I'm not able to get the crash call stack (runs are too old). I'll re-enable the tests and see what happens.
Project Member

Comment 7 by bugdroid1@chromium.org, May 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5fcdbcd466008a0669c1c1e9bcb77ae69010639e

commit 5fcdbcd466008a0669c1c1e9bcb77ae69010639e
Author: fdoray <fdoray@chromium.org>
Date: Fri May 19 12:38:47 2017

Revert of Disable flaky ContinueWhereILeftOffTest.SessionStorage/SessionCookies tests (patchset #1 id:1 of https://codereview.chromium.org/2750783002/ )

Reason for revert:
Re-enabling the tests to see if the issue was fixed or get a call stack if it wasn't. See https://bugs.chromium.org/p/chromium/issues/detail?id=700696#c6

Original issue's description:
> Disable flaky ContinueWhereILeftOffTest.SessionStorage/SessionCookies tests
>
> They are flaky.
>
> BUG= 700696 ,  700699 
> TBR=sky@chromium.org
>
> Review-Url: https://codereview.chromium.org/2750783002
> Cr-Commit-Position: refs/heads/master@{#456659}
> Committed: https://chromium.googlesource.com/chromium/src/+/008c85e4011f9a860f94df75c3bd69c7aece6bab

TBR=yoichio@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 700696 ,  700699 

Review-Url: https://codereview.chromium.org/2892063002
Cr-Commit-Position: refs/heads/master@{#473168}

[modify] https://crrev.com/5fcdbcd466008a0669c1c1e9bcb77ae69010639e/chrome/browser/sessions/better_session_restore_browsertest.cc

Comment 8 by fdoray@chromium.org, May 23 2017

Status: Fixed (was: Untriaged)
No new flakes since the test was re-enabled.

Sign in to add a comment