"PlatformAppBrowserTest.PRE_PRE_ComponentAppBackgroundPage" is flaky |
||||
Issue description"PlatformAppBrowserTest.PRE_PRE_ComponentAppBackgroundPage" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 5 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyRAsSBUZsYWtlIjlQbGF0Zm9ybUFwcEJyb3dzZXJUZXN0LlBSRV9QUkVfQ29tcG9uZW50QXBwQmFja2dyb3VuZFBhZ2UM. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
Mar 17 2017
https://codereview.chromium.org/2630773002 is a culprit
,
Mar 17 2017
,
Mar 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9b35aa2cb18ff78d6cfc843f0e9414ccb6c22150 commit 9b35aa2cb18ff78d6cfc843f0e9414ccb6c22150 Author: thomasanderson <thomasanderson@google.com> Date: Fri Mar 17 19:45:27 2017 X11: Fix test flakes related to window focus This CL removes code intended to fix "some tests depending on a window being IsActive() immediately after an Activate()". After https://codereview.chromium.org/2630773002, all of these cases should be using WidgetActivationWaiter, so this is unnecessary. This was causing DCHECK(!is_active || window_mapped_in_server_) to fail. In addition, XSetInputFocus on an unmapped window will fail, so supress the error in this case. This is the same thing GTK does https://github.com/GNOME/gtk/blob/7ade6e3f4668220f0fa1382944a87e63691ad9ad/gdk/x11/gdkwindow-x11.c#L1904 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_dbg_ng BUG= 701722 , 701921 , 701706 , 701485 , 701484 , 700692 , 700683 , 700661 , 701886 R=erg@chromium.org Review-Url: https://codereview.chromium.org/2756183003 Cr-Commit-Position: refs/heads/master@{#457859} [modify] https://crrev.com/9b35aa2cb18ff78d6cfc843f0e9414ccb6c22150/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc
,
Mar 20 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by chromium...@appspot.gserviceaccount.com
, Mar 14 2017