New issue
Advanced search Search tips

Issue 700682 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Proj-XR

Blocking:
issue 673664



Sign in to add a comment

VRLayer not matching the spec

Project Member Reported by lunalu@chromium.org, Mar 11 2017

Issue description

From the spec https://w3c.github.io/webvr/#interface-vrlayer, VRLayer is supposed to be exposed with a constructor. Currently we don't have a VRLayerInit dictionary in Blink and |leftBounds| and |rightBounds| are not readonly in VRLayer.

Do we have any intention to make it match the spec or update the spec?
 
Labels: VR-OT2 Proj-VR
Owner: bajones@chromium.org
Status: Assigned (was: Untriaged)
https://github.com/w3c/webvr/issues/192#issuecomment-285460424 is probably related. bajones, what should we do here?
Well, there's a couple of things to do here.

First off, the spec that we're following at the moment is actually https://w3c.github.io/webvr/archive/prerelease/1.1/ Seems to me like step number one is to make that spec more prominent for the time being and stop linking people by default to https://w3c.github.io/webvr/, which is in a weird transitional state right now. :P

Second, based on the conversation ddorwin@ linked to we should change the dictionary name to prevent future conflicts. The exact name is something that we'll settle on soon. I'll ping this bug when it's decided on.
Spec shuffling has a pull request up now: https://github.com/w3c/webvr/pull/206

Also, at this point the name of the dictionary in 1.1 is "VRLayerInit". "VRLayer" as a constructable interface only exists in the 2.0 version of the spec.
Potential update without related test cases updated here:
https://codereview.chromium.org/2747373002/
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/840ba3abd75d87629ddfc1ef300c0cc9c803937c

commit 840ba3abd75d87629ddfc1ef300c0cc9c803937c
Author: Brandon Jones <bajones@chromium.org>
Date: Tue Sep 05 18:33:44 2017

Renamed VRLayer to VRLayerInit to match WebVR spec

This won't have any visible effect to developers, since they
never call the dictionary by name. It does however clear a
conflict with the upcoming 2.0 spec, which uses the VRLayer
name.

Bug:  700682 
Change-Id: I39d0b0dab72235b7c088b3ab1eca8959582eb069
Reviewed-on: https://chromium-review.googlesource.com/648078
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Brandon Jones <bajones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499686}
[modify] https://crrev.com/840ba3abd75d87629ddfc1ef300c0cc9c803937c/third_party/WebKit/LayoutTests/external/wpt/webvr/idlharness.html
[modify] https://crrev.com/840ba3abd75d87629ddfc1ef300c0cc9c803937c/third_party/WebKit/Source/modules/modules_idl_files.gni
[modify] https://crrev.com/840ba3abd75d87629ddfc1ef300c0cc9c803937c/third_party/WebKit/Source/modules/vr/VRDisplay.cpp
[modify] https://crrev.com/840ba3abd75d87629ddfc1ef300c0cc9c803937c/third_party/WebKit/Source/modules/vr/VRDisplay.h
[modify] https://crrev.com/840ba3abd75d87629ddfc1ef300c0cc9c803937c/third_party/WebKit/Source/modules/vr/VRDisplay.idl
[rename] https://crrev.com/840ba3abd75d87629ddfc1ef300c0cc9c803937c/third_party/WebKit/Source/modules/vr/VRLayerInit.idl

Status: Fixed (was: Assigned)
Components: Blink>WebXR

Sign in to add a comment