UI_COMPOSITOR_IMAGE_TRANSPORT looks pretty dead, try removing it |
||
Issue descriptionThere are close to no references: https://cs.chromium.org/search/?q=UI_COMPOSITOR_IMAGE_TRANSPORT+package:%5Echromium$&type=cs All .gn references add deps to ui/gl, which chrome already depends on unconditionally. It guards single a glFinish() that runs if posix and not macOS and not UI_COMPOSITOR_IMAGE_TRANSPORT, but UI_COMPOSITOR_IMAGE_TRANSPORT is set on linux&&aura, so I'm not sure that if is alive anywhere.
,
Mar 14 2017
CC'ing a few folks who might be interested in this seemingly dead code removal.
,
Mar 14 2017
At best this would be alive on BSD but uh.. if BSD doesn't use aura then Idk how it would do anything really. This makes me wonder if anyone even builds chrome there anymore heh.
,
Mar 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/81e3d61f4f273627a7fb9d6d7f2bbbc382c95d7e commit 81e3d61f4f273627a7fb9d6d7f2bbbc382c95d7e Author: thakis <thakis@chromium.org> Date: Tue Mar 14 17:17:03 2017 Remove ui_compositor_image_transport, it has no effect. It's been used to add a conditional dep on ui/gl, but we chrome depends on that unconditionally already. It's also been used to call glFinish() under the following conditions in the glResizeCHROMIUM handler: !defined(UI_COMPOSITOR_IMAGE_TRANSPORT) UI_COMPOSITOR_IMAGE_TRANSPORT was always set on Linux and Chrome OS, which means this code only ran on Android, and I'm not sure if we use glResizeCHROMIUM there. BUG=700681 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2748533002 Cr-Commit-Position: refs/heads/master@{#456746} [modify] https://crrev.com/81e3d61f4f273627a7fb9d6d7f2bbbc382c95d7e/build/config/BUILD.gn [modify] https://crrev.com/81e3d61f4f273627a7fb9d6d7f2bbbc382c95d7e/build/config/ui.gni [modify] https://crrev.com/81e3d61f4f273627a7fb9d6d7f2bbbc382c95d7e/chrome/browser/BUILD.gn [modify] https://crrev.com/81e3d61f4f273627a7fb9d6d7f2bbbc382c95d7e/chrome/browser/chromeos/BUILD.gn [modify] https://crrev.com/81e3d61f4f273627a7fb9d6d7f2bbbc382c95d7e/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/81e3d61f4f273627a7fb9d6d7f2bbbc382c95d7e/gpu/command_buffer/service/gles2_cmd_decoder.cc |
||
►
Sign in to add a comment |
||
Comment 1 by thakis@chromium.org
, Mar 11 2017