New issue
Advanced search Search tips

Issue 700673 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security

Blocking:
issue 698865



Sign in to add a comment

Use-of-uninitialized-value in get_object_type

Project Member Reported by ClusterFuzz, Mar 11 2017

Issue description

Project Member

Comment 1 by sheriffbot@chromium.org, Mar 12 2017

Labels: M-58
Project Member

Comment 2 by sheriffbot@chromium.org, Mar 12 2017

Labels: ReleaseBlock-Beta
This issue is a security regression. If you are not able to fix this quickly, please revert the change that introduced it.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 3 by sheriffbot@chromium.org, Mar 12 2017

Labels: Pri-1
Cc: dalecur...@chromium.org
Components: Internals>Media>FFmpeg
Owner: tguilbert@chromium.org
Status: Assigned (was: Untriaged)
Looks very similar to  https://crbug.com/700690 . Can you take a look, please?
Project Member

Comment 5 by sheriffbot@chromium.org, Mar 13 2017

Labels: -Security_Impact-Head Security_Impact-Beta
Blocking: 698865
Yes, I will take a look.
Thanks - just a heads up, we're promoting M58 to Beta this Thursday, and we'll need to address this bug by Wednesday 5PM. This is currently marked as Beta blocking. 
Labels: -ReleaseBlock-Beta
I don't think this should be RBB; it's unlikely to do more than make audio in corrupted file cases sound odd.

Comment 9 by kcc@chromium.org, Mar 13 2017

... which would be a nice attack vector, see 
https://googleprojectzero.blogspot.com/2014/08/what-does-pointer-look-like-anyway.html
Labels: ReleaseBlock-Stable
Sure, I don't mean to discount the vulnerability class; just that this shouldn't be RBB as a non-regression issue.
Project Member

Comment 11 by sheriffbot@chromium.org, Mar 28 2017

tguilbert: Uh oh! This issue still open and hasn't been updated in the last 14 days. This is a serious vulnerability, and we want to ensure that there's progress. Could you please leave an update with the current status and any potential blockers?

If you're not the right owner for this issue, could you please remove yourself as soon as possible or help us find the right one?

If the issue is fixed or you can't reproduce it, please close the bug. If you've started working on a fix, please set the status to Started.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Security_Impact-Beta -ReleaseBlock-Stable Security_Impact-Stable
Project Member

Comment 13 by sheriffbot@chromium.org, Apr 11 2017

tguilbert: Uh oh! This issue still open and hasn't been updated in the last 28 days. This is a serious vulnerability, and we want to ensure that there's progress. Could you please leave an update with the current status and any potential blockers?

If you're not the right owner for this issue, could you please remove yourself as soon as possible or help us find the right one?

If the issue is fixed or you can't reproduce it, please close the bug. If you've started working on a fix, please set the status to Started.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 14 by bugdroid1@chromium.org, Apr 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/third_party/ffmpeg/+/28a5cdde5c32bcf66715343c10f74e85713f7aaf

commit 28a5cdde5c32bcf66715343c10f74e85713f7aaf
Author: Thomas Guilbert <tguilbert@chromium.org>
Date: Wed Apr 12 00:45:40 2017

avformat/oggparseogm: Check available data before reading global header

Fixes use of uninitialized data

Found-by: Thomas Guilbert <tguilbert@google.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 170d864d2c508ca8111b1d108e1e964007dab712)

Bug:700673,  700690 ,  701754 

Change-Id: I90795c2fe9e3c2f29f53f7a5f58339c3e7ca05f6
Reviewed-on: https://chromium-review.googlesource.com/475027
Reviewed-by: Matthew Wolenetz <wolenetz@chromium.org>

[modify] https://crrev.com/28a5cdde5c32bcf66715343c10f74e85713f7aaf/libavformat/oggparseogm.c

Project Member

Comment 15 by ClusterFuzz, Apr 12 2017

ClusterFuzz has detected this issue as fixed in range 463886:463918.

Detailed report: https://clusterfuzz.com/testcase?key=5638058075750400

Fuzzer: libfuzzer_media_pipeline_integration_fuzzer
Job Type: libfuzzer_chrome_msan
Platform Id: linux

Crash Type: Use-of-uninitialized-value
Crash Address: 
Crash State:
  get_object_type
  avpriv_mpeg4audio_get_config
  decode_audio_specific_config
  
Sanitizer: memory (MSAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_msan&range=423366:423427
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_msan&range=463886:463918

Reproducer Testcase: https://clusterfuzz.com/download/AMIfv977g32DlhGQyJUTraoqApA6q7FSLaOL5Dk_XO_KoqPq3AnVu-3UlUZaYJZFIoyVtczqfEUXVafOhoyausgrEHpMsL23cgxtqmASCM50x1m0l6yKq4VoQgKC22BekbNIpWVEFxkOQDE-FnuP75OFS0r0FyMQsqUL-E6qwBbgFu6fAbKllxcpiEw-ZysEbByRH2sslZMl_96pRS-cRKk1N3W8e_93HSifBSsgjsu8mpalETUJk9iR55M7IkZXFYoDf-uI0hh-M-9f7Dt-gDR3OBm1YY5ZFktuVRe_iYUjzE_i4DfWAFe7o0_S4Fz9KXBdNUyF39RTUbnwp5QXZiIVKVZEcwSy8pZoRc8J3y8thrN4I-rw-ZM?testcase_id=5638058075750400


See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 16 by ClusterFuzz, Apr 12 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5638058075750400 is verified as fixed, so closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 17 by sheriffbot@chromium.org, Apr 12 2017

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Labels: -M-58 M-59
Labels: Release-0-M59
Project Member

Comment 20 by sheriffbot@chromium.org, Jul 19 2017

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment