New issue
Advanced search Search tips

Issue 700661 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"ContinueWhereILeftOffTest.PostWithPassword" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Mar 11 2017

Issue description

"ContinueWhereILeftOffTest.PostWithPassword" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyNQsSBUZsYWtlIipDb250aW51ZVdoZXJlSUxlZnRPZmZUZXN0LlBvc3RXaXRoUGFzc3dvcmQM.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 
Project Member

Comment 1 by chromium...@appspot.gserviceaccount.com, Mar 13 2017

Detected 3 new flakes for test/step "ContinueWhereILeftOffTest.PostWithPassword". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyNQsSBUZsYWtlIipDb250aW51ZVdoZXJlSUxlZnRPZmZUZXN0LlBvc3RXaXRoUGFzc3dvcmQM. This message was posted automatically by the chromium-try-flakes app.
Labels: -Sheriff-Chromium Infra-Troopers
This is false alert. Almost from just trying patch not shipped.
Project Member

Comment 3 by chromium...@appspot.gserviceaccount.com, Mar 16 2017

Labels: Sheriff-Chromium
Detected 3 new flakes for test/step "ContinueWhereILeftOffTest.PostWithPassword". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyNQsSBUZsYWtlIipDb250aW51ZVdoZXJlSUxlZnRPZmZUZXN0LlBvc3RXaXRoUGFzc3dvcmQM. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).

Comment 4 by iannu...@google.com, Mar 17 2017

Labels: -Infra-Troopers
I've looked at the logs for these tests, but I don't see any indication that this can be resolved with a trooper action (i.e. manual clobber, machine reboot, software package update, infra software rollback, etc.). When assigning the trooper label please have some action-item in mind.

If you need some trooper assistance for one of the above items, or something similar, please re-add the trooper label and include what system task you suspect is causing the issue.
Labels: -Sheriff-Chromium
Owner: thomasanderson@chromium.org
Suspecting https://codereview.chromium.org/2630773002
Status: Started (was: Untriaged)
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9b35aa2cb18ff78d6cfc843f0e9414ccb6c22150

commit 9b35aa2cb18ff78d6cfc843f0e9414ccb6c22150
Author: thomasanderson <thomasanderson@google.com>
Date: Fri Mar 17 19:45:27 2017

X11: Fix test flakes related to window focus

This CL removes code intended to fix "some tests depending on a window
being IsActive() immediately after an Activate()".  After
https://codereview.chromium.org/2630773002, all of these cases should
be using WidgetActivationWaiter, so this is unnecessary.  This was
causing DCHECK(!is_active || window_mapped_in_server_) to fail.

In addition, XSetInputFocus on an unmapped window will fail, so
supress the error in this case.  This is the same thing GTK does
https://github.com/GNOME/gtk/blob/7ade6e3f4668220f0fa1382944a87e63691ad9ad/gdk/x11/gdkwindow-x11.c#L1904

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_dbg_ng
BUG= 701722 , 701921 , 701706 , 701485 , 701484 , 700692 , 700683 , 700661 , 701886 
R=erg@chromium.org

Review-Url: https://codereview.chromium.org/2756183003
Cr-Commit-Position: refs/heads/master@{#457859}

[modify] https://crrev.com/9b35aa2cb18ff78d6cfc843f0e9414ccb6c22150/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc

Status: Fixed (was: Started)

Sign in to add a comment