ChromeOS OOBE: update EULA screen after UI review. |
||||||||
Issue description4. Google Chrome OS Terms Check design on box surrounding terms of service Scrollbar looks chunky Spacing between checkbox and string
,
Mar 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/781ec99312269de798d55435b8576ed882b0f57b commit 781ec99312269de798d55435b8576ed882b0f57b Author: alemate <alemate@chromium.org> Date: Fri Mar 17 21:18:34 2017 ChromeOS OOBE: Update iframe border of EULA screen. BUG= 700646 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2758733002 Cr-Commit-Position: refs/heads/master@{#457887} [modify] https://crrev.com/781ec99312269de798d55435b8576ed882b0f57b/chrome/browser/resources/chromeos/login/oobe_eula.css
,
Mar 17 2017
Scrollbar of an iframe is controlled by iframe itself. So we should ask ToS owners to implement a new scrollbar if we need.
,
Mar 18 2017
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7628d130006a97f957158fc35aa62404a6c0d4e6 commit 7628d130006a97f957158fc35aa62404a6c0d4e6 Author: Alexander Alekseev <alemate@chromium.org> Date: Sun Mar 19 07:06:26 2017 ChromeOS OOBE: Update iframe border of EULA screen. BUG= 700646 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2758733002 Cr-Commit-Position: refs/heads/master@{#457887} (cherry picked from commit 781ec99312269de798d55435b8576ed882b0f57b) Review-Url: https://codereview.chromium.org/2759863002 . Cr-Commit-Position: refs/branch-heads/3029@{#286} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} [modify] https://crrev.com/7628d130006a97f957158fc35aa62404a6c0d4e6/chrome/browser/resources/chromeos/login/oobe_eula.css
,
Mar 19 2017
,
Mar 19 2017
,
Mar 24 2017
,
Mar 30 2017
Issue 653277 has been merged into this issue.
,
May 24 2017
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by alemate@chromium.org
, Mar 17 2017