New issue
Advanced search Search tips

Issue 700643 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 621719



Sign in to add a comment

ChromeOS OOBE: Let’s go button grows taller when tapped

Project Member Reported by alemate@chromium.org, Mar 11 2017

Issue description

This issue tracks update of Welcome screen.
 
Labels: Merge-Rejected-58 M-58
Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Labels: -Merge-Rejected-58 Merge-Request-58
Status: Fixed (was: Verified)
Requesting merge.
Project Member

Comment 5 by sheriffbot@chromium.org, Mar 25 2017

Labels: -Merge-Request-58 Hotlist-Merge-Approved Merge-Approved-58
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 25 2017

Labels: -merge-approved-58 merge-merged-3029
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/760625b0d22fe5b420cf2bf792680f7cdc0d742a

commit 760625b0d22fe5b420cf2bf792680f7cdc0d742a
Author: Alexander Alekseev <alemate@chromium.org>
Date: Sat Mar 25 09:58:07 2017

ChromeOS OOBE: Fix OK button on Welcome screen.

This Cl fixes issue "Let’s go button grows taller when tapped".

BUG= 700643 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2745843004
Cr-Commit-Position: refs/heads/master@{#456567}
(cherry picked from commit a45b9f4f9b55667f056c46915642691a112a2a3a)

Review-Url: https://codereview.chromium.org/2776013002 .
Cr-Commit-Position: refs/branch-heads/3029@{#418}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/760625b0d22fe5b420cf2bf792680f7cdc0d742a/chrome/browser/resources/chromeos/login/oobe_buttons.html
[modify] https://crrev.com/760625b0d22fe5b420cf2bf792680f7cdc0d742a/chrome/browser/resources/chromeos/login/oobe_screen.css
[modify] https://crrev.com/760625b0d22fe5b420cf2bf792680f7cdc0d742a/chrome/browser/resources/chromeos/login/oobe_text_button.css
[modify] https://crrev.com/760625b0d22fe5b420cf2bf792680f7cdc0d742a/chrome/browser/resources/chromeos/login/oobe_welcome_secondary_button.css

Comment 7 by cda...@chromium.org, May 24 2017

Components: UI>Shell>OOBE

Comment 8 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment