"BrowserCloseManagerBrowserTest/BrowserCloseManagerBrowserTest.TestCloseTabDuringShutdown/0" is flaky |
|||
Issue description"BrowserCloseManagerBrowserTest/BrowserCloseManagerBrowserTest.TestCloseTabDuringShutdown/0" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyZQsSBUZsYWtlIlpCcm93c2VyQ2xvc2VNYW5hZ2VyQnJvd3NlclRlc3QvQnJvd3NlckNsb3NlTWFuYWdlckJyb3dzZXJUZXN0LlRlc3RDbG9zZVRhYkR1cmluZ1NodXRkb3duLzAM. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
Mar 15 2017
,
Mar 28 2017
This might be due to a change that I made. I'm tagging this bug in a fix I'm working on. Once that fix lands, please re-test to see if the flakiness is gone. (Follow along in bug 705306 .)
,
Mar 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/64b8b65b733a3ac8bd0b5f707431f6d1fae20948 commit 64b8b65b733a3ac8bd0b5f707431f6d1fae20948 Author: avi <avi@chromium.org> Date: Wed Mar 29 18:50:34 2017 Fix DevToolsBeforeUnloadTest and BrowserCloseManagerBrowserTest. They were attempting to disable the beforeunload timeout, but the switch provided no longer worked. BUG= 705306 , 418266 , 700271 , 700641 TEST=Linux MSan Tests goes green CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation;master.tryserver.chromium.linux:linux_chromium_msan_rel_ng Review-Url: https://codereview.chromium.org/2777013004 Cr-Commit-Position: refs/heads/master@{#460472} [modify] https://crrev.com/64b8b65b733a3ac8bd0b5f707431f6d1fae20948/chrome/browser/devtools/devtools_sanity_browsertest.cc [modify] https://crrev.com/64b8b65b733a3ac8bd0b5f707431f6d1fae20948/chrome/browser/lifetime/browser_close_manager_browsertest.cc [modify] https://crrev.com/64b8b65b733a3ac8bd0b5f707431f6d1fae20948/content/browser/frame_host/render_frame_host_impl.cc [modify] https://crrev.com/64b8b65b733a3ac8bd0b5f707431f6d1fae20948/content/browser/frame_host/render_frame_host_impl.h [modify] https://crrev.com/64b8b65b733a3ac8bd0b5f707431f6d1fae20948/content/browser/renderer_host/render_widget_host_impl.cc [modify] https://crrev.com/64b8b65b733a3ac8bd0b5f707431f6d1fae20948/content/browser/renderer_host/render_widget_host_impl.h [modify] https://crrev.com/64b8b65b733a3ac8bd0b5f707431f6d1fae20948/content/public/browser/render_frame_host.h [modify] https://crrev.com/64b8b65b733a3ac8bd0b5f707431f6d1fae20948/content/public/browser/render_widget_host.h
,
Mar 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/88040919ebd013468fa71a2976ce08f19481e593 commit 88040919ebd013468fa71a2976ce08f19481e593 Author: avi <avi@chromium.org> Date: Thu Mar 30 03:48:42 2017 Re-enable BrowserCloseManagerBrowserTest.TestCloseTabDuringShutdown. It started flaking about the time that the beforeunload timer was split off, a bug that was just fixed in 64b8b65b733a3ac8bd0b5f707431f6d1fae20948. BUG= 700641 TEST=stays green, doesn't flake Review-Url: https://codereview.chromium.org/2784113002 Cr-Commit-Position: refs/heads/master@{#460650} [modify] https://crrev.com/88040919ebd013468fa71a2976ce08f19481e593/chrome/browser/lifetime/browser_close_manager_browsertest.cc
,
Mar 30 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Mar 14 2017