We will also need a config to enable/disable for both test and compile. It would be great if we could set confidence level, but it's a plus. Need to handle the case that: the same culprit causes a lot of failures in different builders or testers.
We could define the interface so that decouple this task from APIs of code-review.
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/f23ba79ce4fd978bfed2bce8540dbb01f268147a commit f23ba79ce4fd978bfed2bce8540dbb01f268147a Author: Chan <chanli@chromium.org> Date: Wed Mar 15 17:22:55 2017 [Findit] Add ndb model for revert CLs' metadata. BUG= 700639 , 700988 Change-Id: I9b3f7fd173e1d1390de6e876ad2cb947994b6f32 Reviewed-on: https://chromium-review.googlesource.com/454298 Commit-Queue: Chan Li <chanli@chromium.org> Reviewed-by: Jeffrey Li <lijeffrey@chromium.org> [add] https://crrev.com/f23ba79ce4fd978bfed2bce8540dbb01f268147a/appengine/findit/model/revert_cl_status.py [modify] https://crrev.com/f23ba79ce4fd978bfed2bce8540dbb01f268147a/appengine/findit/model/test/base_suspected_cl_test.py [modify] https://crrev.com/f23ba79ce4fd978bfed2bce8540dbb01f268147a/appengine/findit/waterfall/send_notification_for_culprit_pipeline.py [modify] https://crrev.com/f23ba79ce4fd978bfed2bce8540dbb01f268147a/appengine/findit/waterfall/test/send_notification_for_culprit_pipeline_test.py [delete] https://crrev.com/5446b25c45b7f42243bae8323b34beb19b0040d2/appengine/findit/model/test/wf_culprit_test.py [modify] https://crrev.com/f23ba79ce4fd978bfed2bce8540dbb01f268147a/appengine/findit/handlers/test/culprit_test.py [modify] https://crrev.com/f23ba79ce4fd978bfed2bce8540dbb01f268147a/appengine/findit/model/wf_suspected_cl.py [modify] https://crrev.com/f23ba79ce4fd978bfed2bce8540dbb01f268147a/appengine/findit/model/test/wf_suspected_cl_test.py [modify] https://crrev.com/f23ba79ce4fd978bfed2bce8540dbb01f268147a/appengine/findit/handlers/culprit.py [delete] https://crrev.com/5446b25c45b7f42243bae8323b34beb19b0040d2/appengine/findit/model/wf_culprit.py [modify] https://crrev.com/f23ba79ce4fd978bfed2bce8540dbb01f268147a/appengine/findit/model/base_suspected_cl.py
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/d9192299f1fd90a63273955de9c105e939cd749c commit d9192299f1fd90a63273955de9c105e939cd749c Author: Chan <chanli@chromium.org> Date: Thu Mar 16 17:36:37 2017 [Findit] Add pipeline for reverting a culprit for compile failure. BUG= 700639 Change-Id: I86e7209b03af15587c703b7ebb7584074162ca3e Reviewed-on: https://chromium-review.googlesource.com/455401 Commit-Queue: Chan Li <chanli@chromium.org> Reviewed-by: Jeffrey Li <lijeffrey@chromium.org> Reviewed-by: Shuotao Gao <stgao@chromium.org> [add] https://crrev.com/d9192299f1fd90a63273955de9c105e939cd749c/appengine/findit/waterfall/create_revert_cl_pipeline.py [modify] https://crrev.com/d9192299f1fd90a63273955de9c105e939cd749c/appengine/findit/waterfall/test/suspected_cl_util_test.py [modify] https://crrev.com/d9192299f1fd90a63273955de9c105e939cd749c/appengine/findit/infra_api_clients/codereview/rietveld.py [modify] https://crrev.com/d9192299f1fd90a63273955de9c105e939cd749c/appengine/findit/model/base_suspected_cl.py [add] https://crrev.com/d9192299f1fd90a63273955de9c105e939cd749c/appengine/findit/waterfall/test/create_revert_cl_pipeline_test.py [modify] https://crrev.com/d9192299f1fd90a63273955de9c105e939cd749c/appengine/findit/infra_api_clients/codereview/codereview.py [modify] https://crrev.com/d9192299f1fd90a63273955de9c105e939cd749c/appengine/findit/common/constants.py [modify] https://crrev.com/d9192299f1fd90a63273955de9c105e939cd749c/appengine/findit/waterfall/suspected_cl_util.py [modify] https://crrev.com/d9192299f1fd90a63273955de9c105e939cd749c/appengine/findit/infra_api_clients/codereview/cl_info.py
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/6c5dc38f252a0bed557f3201e6e1ab3a9e352110 commit 6c5dc38f252a0bed557f3201e6e1ab3a9e352110 Author: Chan <chanli@chromium.org> Date: Thu Mar 16 18:10:19 2017 [Findit] Link revert culprit pipeline with other pipelines. BUG= 700639 Change-Id: I55813338268c27af246caa650d1bdec8367bedef Reviewed-on: https://chromium-review.googlesource.com/455270 Commit-Queue: Chan Li <chanli@chromium.org> Reviewed-by: Shuotao Gao <stgao@chromium.org> [modify] https://crrev.com/6c5dc38f252a0bed557f3201e6e1ab3a9e352110/appengine/findit/waterfall/test/identify_try_job_culprit_pipeline_test.py [add] https://crrev.com/6c5dc38f252a0bed557f3201e6e1ab3a9e352110/appengine/findit/waterfall/revert_and_notify_culprit_pipeline.py [modify] https://crrev.com/6c5dc38f252a0bed557f3201e6e1ab3a9e352110/appengine/findit/waterfall/test/send_notification_for_culprit_pipeline_test.py [modify] https://crrev.com/6c5dc38f252a0bed557f3201e6e1ab3a9e352110/appengine/findit/waterfall/identify_try_job_culprit_pipeline.py [add] https://crrev.com/6c5dc38f252a0bed557f3201e6e1ab3a9e352110/appengine/findit/waterfall/test/revert_and_notify_culprit_pipeline_test.py [modify] https://crrev.com/6c5dc38f252a0bed557f3201e6e1ab3a9e352110/appengine/findit/waterfall/send_notification_for_culprit_pipeline.py
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/62817496b35f22a6bcf1aa516e6ba9bb3708d271 commit 62817496b35f22a6bcf1aa516e6ba9bb3708d271 Author: Chan <chanli@chromium.org> Date: Thu Mar 16 20:29:35 2017 [Findit] Add config to easily turn on/off the feature of reverting culprits for compile failres. BUG= 700639 Change-Id: Id673b0b319ef371c472c246e4586258845a4ce6d Reviewed-on: https://chromium-review.googlesource.com/456400 Reviewed-by: Shuotao Gao <stgao@chromium.org> Commit-Queue: Chan Li <chanli@chromium.org> [modify] https://crrev.com/62817496b35f22a6bcf1aa516e6ba9bb3708d271/appengine/findit/waterfall/create_revert_cl_pipeline.py [modify] https://crrev.com/62817496b35f22a6bcf1aa516e6ba9bb3708d271/appengine/findit/handlers/test/config_test.py [modify] https://crrev.com/62817496b35f22a6bcf1aa516e6ba9bb3708d271/appengine/findit/handlers/config.py [modify] https://crrev.com/62817496b35f22a6bcf1aa516e6ba9bb3708d271/appengine/findit/waterfall/test/waterfall_config_test.py [modify] https://crrev.com/62817496b35f22a6bcf1aa516e6ba9bb3708d271/appengine/findit/waterfall/test/wf_testcase.py [modify] https://crrev.com/62817496b35f22a6bcf1aa516e6ba9bb3708d271/appengine/findit/waterfall/test/create_revert_cl_pipeline_test.py [modify] https://crrev.com/62817496b35f22a6bcf1aa516e6ba9bb3708d271/appengine/findit/model/wf_config.py
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/8aef78327b96b77fe0f75bd82435dda914103e82 commit 8aef78327b96b77fe0f75bd82435dda914103e82 Author: Chan <chanli@chromium.org> Date: Thu Mar 16 21:54:57 2017 [Findit] yield RevertAndNotifyCulpritPipeline to allow collect failures if abort. BUG= 700639 Change-Id: I31204659da824284ff8b5f17343cf46e8dd0ec73 Reviewed-on: https://chromium-review.googlesource.com/456818 Reviewed-by: Roberto Carrillo <robertocn@chromium.org> Reviewed-by: Shuotao Gao <stgao@chromium.org> Commit-Queue: Chan Li <chanli@chromium.org> [modify] https://crrev.com/8aef78327b96b77fe0f75bd82435dda914103e82/appengine/findit/waterfall/identify_try_job_culprit_pipeline.py [modify] https://crrev.com/8aef78327b96b77fe0f75bd82435dda914103e82/appengine/findit/waterfall/test/identify_try_job_culprit_pipeline_test.py
Comment 1 by st...@chromium.org
, Mar 11 2017