New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 700636 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: 2
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 700627



Sign in to add a comment

Show reverting CL on SoM

Project Member Reported by st...@chromium.org, Mar 11 2017

Issue description

We need to figure out what info and how to show on SoM.
 

Comment 1 by chanli@chromium.org, Mar 13 2017

EstimatedDays: 2
Status: Started (was: Assigned)

Comment 2 by chanli@chromium.org, Mar 13 2017

Possible way to display the reverting CL:
1. Add a sentence after Findit result:
findit Findit (?) found culprit 0510799 with 100% confidence. More details...  Reverting CL (url) has been created, PLEASE CHECK.

2. Add a header under tree close:
Tree is closed ...
Findit created a reverting CL(url) for the culprit (rev) of this tree close. PLEASE CHECK(or CONFIRM).
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/8de90094826b34437113a6356efce9273432e691

commit 8de90094826b34437113a6356efce9273432e691
Author: Chan <chanli@chromium.org>
Date: Wed Mar 15 18:16:45 2017

[Findit] Add reverting CL url to the response of Findit API.

BUG= 700636 

Change-Id: Ieeeee7f73d398a0111c312a1f7110e552ad62f50
Reviewed-on: https://chromium-review.googlesource.com/453885
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Reviewed-by: Jeffrey Li <lijeffrey@chromium.org>
Commit-Queue: Chan Li <chanli@chromium.org>

[modify] https://crrev.com/8de90094826b34437113a6356efce9273432e691/appengine/findit/test/findit_api_test.py
[modify] https://crrev.com/8de90094826b34437113a6356efce9273432e691/appengine/findit/findit_api.py

Project Member

Comment 4 by bugdroid1@chromium.org, Mar 15 2017

Comment 5 by st...@chromium.org, Mar 16 2017

Status: Fixed (was: Started)

Sign in to add a comment