New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 700635 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2017
Cc:
Components:
EstimatedDays: 1
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 700628

Blocking:
issue 700627
issue 700639



Sign in to add a comment

Add sherrifs as reviewers of the reverting CL

Project Member Reported by st...@chromium.org, Mar 11 2017

Issue description

Given a issue id, and a list of sheriffs, publish the CL for the sheriffs to review.

API: /<issue>/publish

Request: a POST request with following parameters
* xsrf_token
* message_only=false
* add_as_reviewer=false
* send_mail=true
* no_redirect=true: when set to true, the response is just 'OK' upon success.
* commit=false: Set as false to not commit the CL
* reviewers : ',' separated email list
* cc: ',' separated email list
* in_reply_to: optional, use to reply to the revert in the original CL
* message: the content of the message to publish

Response: a string 'OK' upon success

Code: https://cs.chromium.org/chromium/infra/appengine/chromium_rietveld/codereview/views.py?l=3313
 

Comment 1 by st...@chromium.org, Mar 11 2017

Need to retrieve the original reviewer and cc list first to avoid removing any of them.

Comment 2 by st...@chromium.org, Mar 11 2017

Blockedon: 700628
Labels: Milestone-PreAutoRevert

Comment 3 by st...@chromium.org, Mar 11 2017

Blocking: 700639

Comment 4 by st...@chromium.org, Mar 13 2017

Owner: st...@chromium.org
Status: Assigned (was: Available)
Owner: robert...@chromium.org

Comment 6 by st...@chromium.org, Mar 13 2017

Summary: Add sherrifs as reviewers of the reverting CL (was: Send the reverting CL to sheriffs for review)

Comment 7 by st...@chromium.org, Mar 14 2017

Description: Show this description
EstimatedDays: 1
Project Member

Comment 9 by bugdroid1@chromium.org, Mar 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/4afc175c95ef8370069a4715b893df9af7ad5758

commit 4afc175c95ef8370069a4715b893df9af7ad5758
Author: Roberto Carrillo <robertocn@google.com>
Date: Tue Mar 14 22:57:38 2017

[Findit] Adding stub for rietveld's AddReviewers

R=chanli,stgao
BUG= 700635 

Change-Id: I6ef43d2233b44672202f61940b6de52e2b356dde
Reviewed-on: https://chromium-review.googlesource.com/454000
Commit-Queue: Roberto Carrillo <robertocn@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>

[modify] https://crrev.com/4afc175c95ef8370069a4715b893df9af7ad5758/appengine/findit/infra_api_clients/codereview/codereview.py
[modify] https://crrev.com/4afc175c95ef8370069a4715b893df9af7ad5758/appengine/findit/infra_api_clients/codereview/rietveld.py

Status: Started (was: Assigned)
Project Member

Comment 11 by bugdroid1@chromium.org, Mar 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/c80dfe077f3d5e5cbd108e93de7471f46ee0eba8

commit c80dfe077f3d5e5cbd108e93de7471f46ee0eba8
Author: Roberto Carrillo <robertocn@google.com>
Date: Wed Mar 15 23:19:13 2017

[Findit] Implement AddReviewers api for rietveld codereview.

This api lets us add a list of emails as reviewers to a rietveld
codereview, and optionally customize the message for the addition.

R=chanli,lijeffrey,stgao
BUG= 700635 

Change-Id: I4852998e992a12bbe5db225cff99eebac37b82a6
Reviewed-on: https://chromium-review.googlesource.com/455472
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Commit-Queue: Roberto Carrillo <robertocn@chromium.org>

[modify] https://crrev.com/c80dfe077f3d5e5cbd108e93de7471f46ee0eba8/appengine/findit/infra_api_clients/codereview/rietveld.py
[modify] https://crrev.com/c80dfe077f3d5e5cbd108e93de7471f46ee0eba8/appengine/findit/infra_api_clients/codereview/test/rietveld_test.py

Comment 12 by st...@chromium.org, Mar 16 2017

Status: Fixed (was: Started)

Sign in to add a comment