New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 700628 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2017
Cc:
Components:
EstimatedDays: 1
NextAction: ----
OS: ----
Pri: 2
Type: Bug


Sign in to add a comment

Retrieve info about a CL

Project Member Reported by st...@chromium.org, Mar 11 2017

Issue description

Given a issue id on Rietveld, we need the following info:
     * which patchset id is committed as which revision
     * which patchset has already been reverted (as a plus, by which issue?)
     * Whether it is closed (like as a result of commit)

Rietveld API:
https://codereview.chromium.org/api/2700293002?messages=true
https://codereview.chromium.org/2700293002

Solution: use regex to match and extract info from message.
 

Comment 1 by st...@chromium.org, Mar 11 2017

Labels: Milestone-PreAutoRevert

Comment 2 by st...@chromium.org, Mar 11 2017

Blocking: 700630

Comment 3 by st...@chromium.org, Mar 11 2017

Also retrieve the reviewer and cc list to be used when publishing a CL for review.

Comment 4 by st...@chromium.org, Mar 11 2017

Blocking: 700635

Comment 5 by st...@chromium.org, Mar 11 2017

Blocking: 700639
Owner: robert...@chromium.org
EstimatedDays: 1
Status: Started (was: Available)

Comment 8 by st...@chromium.org, Mar 13 2017

Description: Show this description
Project Member

Comment 9 by bugdroid1@chromium.org, Mar 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/5446b25c45b7f42243bae8323b34beb19b0040d2

commit 5446b25c45b7f42243bae8323b34beb19b0040d2
Author: Roberto Carrillo <robertocn@google.com>
Date: Wed Mar 15 17:02:29 2017

[Findit] Get information regarding a cl to be reverted

This new method extracts the following information from rietveld, for a
given issue url:
 - Which patchsets were committed as which revisions
 - Which patchsets were reverted by which issue_url
 - Whether the issue is closed

 R=chanli, stgao
 BUG= 700628 

Change-Id: Iebdf78951110eec6a1bb5bc44c19b823c33f61c1
Reviewed-on: https://chromium-review.googlesource.com/454178
Commit-Queue: Roberto Carrillo <robertocn@chromium.org>
Reviewed-by: Chan Li <chanli@chromium.org>
Reviewed-by: Jeffrey Li <lijeffrey@chromium.org>

[modify] https://crrev.com/5446b25c45b7f42243bae8323b34beb19b0040d2/appengine/findit/libs/time_util.py
[modify] https://crrev.com/5446b25c45b7f42243bae8323b34beb19b0040d2/appengine/findit/infra_api_clients/codereview/rietveld.py
[add] https://crrev.com/5446b25c45b7f42243bae8323b34beb19b0040d2/appengine/findit/infra_api_clients/codereview/test/reverttestissuedetails.json
[modify] https://crrev.com/5446b25c45b7f42243bae8323b34beb19b0040d2/appengine/findit/infra_api_clients/codereview/codereview.py
[modify] https://crrev.com/5446b25c45b7f42243bae8323b34beb19b0040d2/appengine/findit/infra_api_clients/codereview/test/rietveld_test.py
[add] https://crrev.com/5446b25c45b7f42243bae8323b34beb19b0040d2/appengine/findit/infra_api_clients/codereview/test/testissuedetails.json
[add] https://crrev.com/5446b25c45b7f42243bae8323b34beb19b0040d2/appengine/findit/infra_api_clients/codereview/cl_info.py

Status: Fixed (was: Started)

Sign in to add a comment