New issue
Advanced search Search tips

Issue 700616 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Linux remoting code used deprecated gtk_misc calls

Project Member Reported by sbc@chromium.org, Mar 11 2017

Issue description

This only shows up with the new jessie sysroots but:

../../remoting/host/continue_window_linux.cc:105:24: error: 'gtk_misc_get_type' is deprecated [-Werror,-Wdeprecated-declarations]
  gtk_misc_set_padding(GTK_MISC(text_label), 12, 12);
                       ^
../../build/linux/debian_jessie_amd64-sysroot/usr/include/gtk-3.0/gtk/deprecated/gtkmisc.h:39:67: note: expanded from macro 'GTK_MISC'
#define GTK_MISC(obj)                  (G_TYPE_CHECK_INSTANCE_CAST ((obj), GTK_TYPE_MISC, GtkMisc))
                                                                           ^
../../build/linux/debian_jessie_amd64-sysroot/usr/include/gtk-3.0/gtk/deprecated/gtkmisc.h:38:32: note: expanded from macro 'GTK_TYPE_MISC'
#define GTK_TYPE_MISC                  (gtk_misc_get_type ())
                                        ^
../../build/linux/debian_jessie_amd64-sysroot/usr/include/gtk-3.0/gtk/deprecated/gtkmisc.h:70:9: note: 'gtk_misc_get_type' has been explicitly marked deprecated here
GType   gtk_misc_get_type      (void) G_GNUC_CONST;
        ^
../../remoting/host/continue_window_linux.cc:105:3: error: 'gtk_misc_set_padding' is deprecated [-Werror,-Wdeprecated-declarations]
  gtk_misc_set_padding(GTK_MISC(text_label), 12, 12);
  ^
../../build/linux/debian_jessie_amd64-sysroot/usr/include/gtk-3.0/gtk/deprecated/gtkmisc.h:80:6: note: 'gtk_misc_set_padding' has been explicitly marked deprecated here
void    gtk_misc_set_padding   (GtkMisc *misc,
        ^
2 errors generated.

I'm currently trying to land this change to update the sysroots and these failures are currently blocking:
https://codereview.chromium.org/2361223002/

 
Status: Fixed (was: Untriaged)
Fixed by https://codereview.chromium.org/2741943004/

Sign in to add a comment