Issue metadata
Sign in to add a comment
|
Chrome won't run when access to wkssvc is denied
Reported by
term...@gmail.com,
Mar 11 2017
|
||||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/57.0.2987.98 Safari/537.36 Steps to reproduce the problem: I recently upgraded from Chrome 56.0.2924.87 to Chrome 57.0.2987.98 on Windows 7 x64 Enterprise and now Chrome will not run. On these machines there is a proprietary tool that locks down the workstation and limits certain types of access to some devices such as \Device\NamedPipe\wkssvc. Because of this the new Chrome will not run. What is the expected behavior? Chrome should ignore the failed access to wkssvc. What went wrong? I bisected Chromium: You are probably looking for a change made after 442679 (known good), but no later than 442694 (first known bad). CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/42968739363fbecc9515b3631d2e05ac7046fb02..63f9112d35ca0514c9eab4b8bc538f277a6343b0 On review of the changes made by these commits this is the only one I can see likely to have caused the issue: 80353b5 Add enrolled to domain bit to crash keys in renderer process. by georgesak ยท 8 weeks ago The associated issue is https://bugs.chromium.org/p/chromium/issues/detail?id=660868 Did this work before? Yes 56.0.2924.87 Chrome version: 57.0.2987.98 Channel: stable OS Version: 6.1 (Windows 7, Windows Server 2008 R2) Flash Version: Shockwave Flash 24.0 r0 While I'm aware this is atypical I would ask that you consider offering a way to disable whatever this is doing, or make it continue on error, should it turn out to be the problem. If you have a trybuild (firefox dialect) or some such I can try it for you to help narrow the problem further and confirm this is the offending commit. Also if you'd prefer I open a new issue that is fine as well.
,
Mar 12 2017
,
Mar 13 2017
This is the continuation discussed here https://bugs.chromium.org/p/chromium/issues/detail?id=660868 so assigning to Georges as he suggested in the other bug.
,
Mar 13 2017
Can you try Canary by any chance? There's a fix that might be related that landed on Friday. https://bugs.chromium.org/p/chromium/issues/detail?id=700371 Otherwise, I can build you a Chromium with a revert of my CL to confirm that this is indeed the source of the issue. Thanks!
,
Mar 13 2017
,
Mar 13 2017
I've been able to repro and confirm that https://codereview.chromium.org/2618623003 is the culprit. Revert on its way.
,
Mar 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bb0b93c87ade82c71918630893164754ea4a1f1e commit bb0b93c87ade82c71918630893164754ea4a1f1e Author: georgesak <georgesak@chromium.org> Date: Mon Mar 13 20:38:47 2017 Reverting 2618623003. Call to IsOS will fail if \Device\NamedPipe\wkssvc is blocked (ie. Chrome is running in a sandbox). BUG= 700615 ,660868 TBR=nasko Review-Url: https://codereview.chromium.org/2747873002 Cr-Commit-Position: refs/heads/master@{#456469} [modify] https://crrev.com/bb0b93c87ade82c71918630893164754ea4a1f1e/content/renderer/render_process_impl.cc
,
Mar 13 2017
,
Mar 13 2017
This bug requires manual review: Only 0 days from stable, we might already have a stable candidate build Please contact the milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 13 2017
Pls update the bug with Canary result tomorrow. If canary data looks good and it is a safe revert merge, I will approve the merge to M57. Thank you.
,
Mar 14 2017
Just tested on Canary, I can confirm that the fix works.
,
Mar 14 2017
Thank you georgesak@ for confirming fix works in Canary. Any regression observed due to this revert?
,
Mar 14 2017
No regression. This is as safe of a revert as there is :)
,
Mar 14 2017
Approving merge to M57 branch 2987 based on comment #11 and #13. Please merge ASAP. Thank you. Please request a merge to M58 as well.
,
Mar 14 2017
,
Mar 14 2017
I can confirm canary works here. Version 59.0.3041.0 (Developer Build) (32-bit) It didn't say that version when I downloaded it, I went to https://omahaproxy.appspot.com/ to find canary and it lists 456562 so I downloaded that chrome-win32.zip from https://commondatastorage.googleapis.com/chromium-browser-snapshots/index.html?prefix=Win/456562/ But nevertheless I think it's the right version. If there is a more correct way to download individual canary builds and you want me to do that please let me know.
,
Mar 14 2017
@16 That's the newest Canary and it has the revert. Thanks for confirming. I'm merging to 57 & 58.
,
Mar 14 2017
Great, thanks for the quick fix!
,
Mar 14 2017
georgesak@, could you please write a postmortem for this. Thank you.
,
Mar 14 2017
,
Mar 14 2017
Approving merge to M58 branch 3029 based on comment #14 and #16. Please merge ASAP. Thank you.
,
Mar 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7e40940cf24e1f459433a1f7207217ee6b37958a commit 7e40940cf24e1f459433a1f7207217ee6b37958a Author: georgesak <georgesak@chromium.org> Date: Tue Mar 14 20:36:13 2017 Reverting 2618623003. Call to IsOS will fail if \Device\NamedPipe\wkssvc is blocked (ie. Chrome is running in a sandbox). BUG= 700615 ,660868 TBR=nasko NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2747873002 Cr-Commit-Position: refs/heads/master@{#456469} (cherry picked from commit bb0b93c87ade82c71918630893164754ea4a1f1e) Review-Url: https://codereview.chromium.org/2749863003 Cr-Commit-Position: refs/branch-heads/2987@{#823} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} [modify] https://crrev.com/7e40940cf24e1f459433a1f7207217ee6b37958a/content/renderer/render_process_impl.cc
,
Mar 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/81d88b89a7d02871ec89836c626c7de314498b81 commit 81d88b89a7d02871ec89836c626c7de314498b81 Author: georgesak <georgesak@chromium.org> Date: Tue Mar 14 20:50:41 2017 Reverting 2618623003. Call to IsOS will fail if \Device\NamedPipe\wkssvc is blocked (ie. Chrome is running in a sandbox). BUG= 700615 ,660868 TBR=nasko NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2747873002 Cr-Commit-Position: refs/heads/master@{#456469} (cherry picked from commit bb0b93c87ade82c71918630893164754ea4a1f1e) Review-Url: https://codereview.chromium.org/2747083004 Cr-Commit-Position: refs/branch-heads/3029@{#196} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} [modify] https://crrev.com/81d88b89a7d02871ec89836c626c7de314498b81/content/renderer/render_process_impl.cc
,
Mar 15 2017
govind@, will do.
,
Mar 15 2017
Thank you (please see go/chrome-postmortems for the process to follow).
,
Mar 16 2017
georgesak@, could you please verify this bug on latest M57 #57.0.2987.110. Thank you.
,
Mar 27 2017
Requesting a postmortem for this (please see go/chrome-postmortems for the process to follow). Thank you.
,
Apr 4 2017
@govind Apologies for the tardiness. Postmortem has been written (although it's my first one so do let me know if something's not right with it). Thanks! Also I can confirm that it's been fixed in all channels. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by gov...@chromium.org
, Mar 12 2017Labels: M-57