New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 700608 link

Starred by 2 users
Status: Verified
Owner:
█ scottchen@chromium.org
Last visit > 30 days ago
Closed: Mar 2017
Cc:
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

MD Settings: iron-list items should not have container focus outlines nor be in the sequential tab order

Project Member Reported by dbeam@chromium.org, Mar 11 2017 
0. navigate to chrome://settings/searchEngines
1. press tab to get to your list of search engines

what do you expect?
no focus outlines on iron-list containers
focus goes to the ... menu, not a container (which isn't really a control)

what happens instead?
the reverse of my expectations (container is focused, shows big blue outline)
Screen Shot 2017-03-10 at 6.02.48 PM.png
46.2 KB View Download

Comment 1 by dbeam@chromium.org, Mar 11 2017 

oh yeah, and pressing up and down while focused on the ... button should focus the next or previous ... button

Comment 2 by scottchen@chromium.org, Mar 13 2017

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/12e779b85deea4e5752fc02631aa9c3718aeb63e

commit 12e779b85deea4e5752fc02631aa9c3718aeb63e
Author: scottchen <scottchen@chromium.org>
Date: Wed Mar 22 23:29:31 2017

MD Settings: adjust iron-list focus row behaviors.

In an effort to bring iron-list focus behaviors closer to other webUIs, this CL extracts code relating to "cr.ui.FocusRow" from MD history's <history-item>, and encapsulates it in a new FocusRowBehavior to be reused by other iron-list row custom elements.

BUG= 700608 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2749513004
Cr-Commit-Position: refs/heads/master@{#458930}

[modify] https://crrev.com/12e779b85deea4e5752fc02631aa9c3718aeb63e/chrome/browser/resources/settings/compiled_resources2.gyp
[add] https://crrev.com/12e779b85deea4e5752fc02631aa9c3718aeb63e/chrome/browser/resources/settings/focus_row_behavior.html
[add] https://crrev.com/12e779b85deea4e5752fc02631aa9c3718aeb63e/chrome/browser/resources/settings/focus_row_behavior.js
[delete] https://crrev.com/226e88f271fb6fc8a47110d440c9e12662edec95/chrome/browser/resources/settings/focusable_iron_list_item_behavior.html
[delete] https://crrev.com/226e88f271fb6fc8a47110d440c9e12662edec95/chrome/browser/resources/settings/focusable_iron_list_item_behavior.js
[modify] https://crrev.com/12e779b85deea4e5752fc02631aa9c3718aeb63e/chrome/browser/resources/settings/on_startup_page/compiled_resources2.gyp
[modify] https://crrev.com/12e779b85deea4e5752fc02631aa9c3718aeb63e/chrome/browser/resources/settings/on_startup_page/startup_url_entry.html
[modify] https://crrev.com/12e779b85deea4e5752fc02631aa9c3718aeb63e/chrome/browser/resources/settings/on_startup_page/startup_url_entry.js
[modify] https://crrev.com/12e779b85deea4e5752fc02631aa9c3718aeb63e/chrome/browser/resources/settings/on_startup_page/startup_urls_page.html
[modify] https://crrev.com/12e779b85deea4e5752fc02631aa9c3718aeb63e/chrome/browser/resources/settings/on_startup_page/startup_urls_page.js
[modify] https://crrev.com/12e779b85deea4e5752fc02631aa9c3718aeb63e/chrome/browser/resources/settings/search_engines_page/compiled_resources2.gyp
[modify] https://crrev.com/12e779b85deea4e5752fc02631aa9c3718aeb63e/chrome/browser/resources/settings/search_engines_page/search_engine_entry.html
[modify] https://crrev.com/12e779b85deea4e5752fc02631aa9c3718aeb63e/chrome/browser/resources/settings/search_engines_page/search_engine_entry.js
[modify] https://crrev.com/12e779b85deea4e5752fc02631aa9c3718aeb63e/chrome/browser/resources/settings/search_engines_page/search_engines_list.html
[modify] https://crrev.com/12e779b85deea4e5752fc02631aa9c3718aeb63e/chrome/browser/resources/settings/search_engines_page/search_engines_list.js
[modify] https://crrev.com/12e779b85deea4e5752fc02631aa9c3718aeb63e/chrome/browser/resources/settings/settings_resources.grd
[modify] https://crrev.com/12e779b85deea4e5752fc02631aa9c3718aeb63e/chrome/browser/resources/settings/settings_shared_css.html
[modify] https://crrev.com/12e779b85deea4e5752fc02631aa9c3718aeb63e/chrome/test/BUILD.gn
[modify] https://crrev.com/12e779b85deea4e5752fc02631aa9c3718aeb63e/chrome/test/data/webui/settings/cr_settings_browsertest.js
[add] https://crrev.com/12e779b85deea4e5752fc02631aa9c3718aeb63e/chrome/test/data/webui/settings/cr_settings_interactive_ui_tests.js
[add] https://crrev.com/12e779b85deea4e5752fc02631aa9c3718aeb63e/chrome/test/data/webui/settings/focus_row_behavior_test.js
[delete] https://crrev.com/226e88f271fb6fc8a47110d440c9e12662edec95/chrome/test/data/webui/settings/focusable_iron_list_item_behavior_test.js
[modify] https://crrev.com/12e779b85deea4e5752fc02631aa9c3718aeb63e/ui/webui/resources/js/cr/ui/focus_row.js

Comment 4 by scottchen@chromium.org, Mar 23 2017

Status: Fixed (was: Started)

Comment 5 by sdantul...@chromium.org, May 9 2017

Status: Verified (was: Fixed)
9534.0.0, 60.0.3092.0
►

Sign in to add a comment