Found by ./tools/git/mass-rename.py while working on Issue 700581 . chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.h [1] [1] https://cs.chromium.org/chromium/src/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.h?q=permission_bubble_controller.h&dr
There are many many more files than just permission_bubble_controller.h which are missing include guards. I'll try and get all of them.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/81c5524dfe7a67cb4fc12026ffc9e5f87b13167d commit 81c5524dfe7a67cb4fc12026ffc9e5f87b13167d Author: dominickn <dominickn@chromium.org> Date: Tue Mar 14 05:24:00 2017 Add missing include guards in Cocoa code. This CL adds the usual Chromium include guard to Cocoa files which are missing it. It also moves comments in some files to ensure that the guard is consistently placed as the first lines after the initial license text in each header. The files were found by running the following shell script: find chrome/browser/ui/cocoa/ -name "*.h" -print0 | xargs -n1 -0 awk ' \ BEGIN { \ toprint = 0; \ } { \ if ($0 ~ /^.ifndef/) { \ toprint = 1; \ exit 0; \ } else if (NR == 5) { \ exit 0; \ } \ } END { \ if (toprint == 0) { \ print FILENAME; \ } \ }' BUG= 700604 Review-Url: https://codereview.chromium.org/2747693003 Cr-Commit-Position: refs/heads/master@{#456628} [modify] https://crrev.com/81c5524dfe7a67cb4fc12026ffc9e5f87b13167d/chrome/browser/ui/cocoa/base_bubble_controller.h [modify] https://crrev.com/81c5524dfe7a67cb4fc12026ffc9e5f87b13167d/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_bridge.h [modify] https://crrev.com/81c5524dfe7a67cb4fc12026ffc9e5f87b13167d/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_constants.h [modify] https://crrev.com/81c5524dfe7a67cb4fc12026ffc9e5f87b13167d/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_hover_state.h [modify] https://crrev.com/81c5524dfe7a67cb4fc12026ffc9e5f87b13167d/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_view.h [modify] https://crrev.com/81c5524dfe7a67cb4fc12026ffc9e5f87b13167d/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_toolbar_view.h [modify] https://crrev.com/81c5524dfe7a67cb4fc12026ffc9e5f87b13167d/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_view_cocoa.h [modify] https://crrev.com/81c5524dfe7a67cb4fc12026ffc9e5f87b13167d/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.h [modify] https://crrev.com/81c5524dfe7a67cb4fc12026ffc9e5f87b13167d/chrome/browser/ui/cocoa/bookmarks/bookmark_button.h [modify] https://crrev.com/81c5524dfe7a67cb4fc12026ffc9e5f87b13167d/chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge.h [modify] https://crrev.com/81c5524dfe7a67cb4fc12026ffc9e5f87b13167d/chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.h [modify] https://crrev.com/81c5524dfe7a67cb4fc12026ffc9e5f87b13167d/chrome/browser/ui/cocoa/bookmarks/bookmark_model_observer_for_cocoa.h [modify] https://crrev.com/81c5524dfe7a67cb4fc12026ffc9e5f87b13167d/chrome/browser/ui/cocoa/bubble_combobox.h [modify] https://crrev.com/81c5524dfe7a67cb4fc12026ffc9e5f87b13167d/chrome/browser/ui/cocoa/bubble_view.h [modify] https://crrev.com/81c5524dfe7a67cb4fc12026ffc9e5f87b13167d/chrome/browser/ui/cocoa/content_settings/collected_cookies_mac.h [modify] https://crrev.com/81c5524dfe7a67cb4fc12026ffc9e5f87b13167d/chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.h [modify] https://crrev.com/81c5524dfe7a67cb4fc12026ffc9e5f87b13167d/chrome/browser/ui/cocoa/content_settings/cookie_details.h [modify] https://crrev.com/81c5524dfe7a67cb4fc12026ffc9e5f87b13167d/chrome/browser/ui/cocoa/content_settings/cookie_details_view_controller.h [modify] https://crrev.com/81c5524dfe7a67cb4fc12026ffc9e5f87b13167d/chrome/browser/ui/cocoa/content_settings/cookie_tree_node.h [modify] https://crrev.com/81c5524dfe7a67cb4fc12026ffc9e5f87b13167d/chrome/browser/ui/cocoa/custom_frame_view.h [modify] https://crrev.com/81c5524dfe7a67cb4fc12026ffc9e5f87b13167d/chrome/browser/ui/cocoa/dock_icon.h [modify] https://crrev.com/81c5524dfe7a67cb4fc12026ffc9e5f87b13167d/chrome/browser/ui/cocoa/download/download_item_button.h [modify] https://crrev.com/81c5524dfe7a67cb4fc12026ffc9e5f87b13167d/chrome/browser/ui/cocoa/download/download_item_controller.h [modify] https://crrev.com/81c5524dfe7a67cb4fc12026ffc9e5f87b13167d/chrome/browser/ui/cocoa/download/download_shelf_context_menu_controller.h [modify] https://crrev.com/81c5524dfe7a67cb4fc12026ffc9e5f87b13167d/chrome/browser/ui/cocoa/download/download_shelf_controller.h [modify] https://crrev.com/81c5524dfe7a67cb4fc12026ffc9e5f87b13167d/chrome/browser/ui/cocoa/download/download_show_all_button.h [modify] https://crrev.com/81c5524dfe7a67cb4fc12026ffc9e5f87b13167d/chrome/browser/ui/cocoa/external_protocol_dialog.h [modify] https://crrev.com/81c5524dfe7a67cb4fc12026ffc9e5f87b13167d/chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.h [modify] https://crrev.com/81c5524dfe7a67cb4fc12026ffc9e5f87b13167d/chrome/browser/ui/cocoa/find_bar/find_bar_text_field.h [modify] https://crrev.com/81c5524dfe7a67cb4fc12026ffc9e5f87b13167d/chrome/browser/ui/cocoa/find_bar/find_bar_text_field_cell.h [modify] https://crrev.com/81c5524dfe7a67cb4fc12026ffc9e5f87b13167d/chrome/browser/ui/cocoa/first_run_bubble_controller.h [modify] https://crrev.com/81c5524dfe7a67cb4fc12026ffc9e5f87b13167d/chrome/browser/ui/cocoa/fullscreen_window.h [modify] https://crrev.com/81c5524dfe7a67cb4fc12026ffc9e5f87b13167d/chrome/browser/ui/cocoa/history_menu_cocoa_controller.h [modify] https://crrev.com/81c5524dfe7a67cb4fc12026ffc9e5f87b13167d/chrome/browser/ui/cocoa/info_bubble_window.h [modify] https://crrev.com/81c5524dfe7a67cb4fc12026ffc9e5f87b13167d/chrome/browser/ui/cocoa/infobars/after_translate_infobar_controller.h [modify] https://crrev.com/81c5524dfe7a67cb4fc12026ffc9e5f87b13167d/chrome/browser/ui/cocoa/infobars/before_translate_infobar_controller.h [modify] https://crrev.com/81c5524dfe7a67cb4fc12026ffc9e5f87b13167d/chrome/browser/ui/cocoa/infobars/infobar_controller.h [modify] https://crrev.com/81c5524dfe7a67cb4fc12026ffc9e5f87b13167d/chrome/browser/ui/cocoa/infobars/translate_message_infobar_controller.h [modify] https://crrev.com/81c5524dfe7a67cb4fc12026ffc9e5f87b13167d/chrome/browser/ui/cocoa/l10n_util.h [modify] https://crrev.com/81c5524dfe7a67cb4fc12026ffc9e5f87b13167d/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.h [modify] https://crrev.com/81c5524dfe7a67cb4fc12026ffc9e5f87b13167d/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.h [modify] https://crrev.com/81c5524dfe7a67cb4fc12026ffc9e5f87b13167d/chrome/browser/ui/cocoa/styled_text_field.h [modify] https://crrev.com/81c5524dfe7a67cb4fc12026ffc9e5f87b13167d/chrome/browser/ui/cocoa/test/styled_text_field_test_helper.h [modify] https://crrev.com/81c5524dfe7a67cb4fc12026ffc9e5f87b13167d/chrome/browser/ui/cocoa/translate/translate_bubble_controller.h [modify] https://crrev.com/81c5524dfe7a67cb4fc12026ffc9e5f87b13167d/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.h [modify] https://crrev.com/81c5524dfe7a67cb4fc12026ffc9e5f87b13167d/chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.h
❤ Thanks for fixing all those. :-)
Comment 1 by dominickn@chromium.org
, Mar 14 2017Status: Started (was: Available)