New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 700601 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Mar 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

arc: No Play Store item in app launcher for managed user.

Project Member Reported by khmel@chromium.org, Mar 11 2017

Issue description

It is expected that for managed used Play Store exists and clicking it re-activate OptIn flow if it was canceled for some reason before.

Inner bug b/36043525
 

Comment 2 by khmel@chromium.org, Mar 17 2017

Cc: bhthompson@chromium.org
Labels: Merge-Request-58
Project Member

Comment 3 by sheriffbot@chromium.org, Mar 17 2017

Labels: -Merge-Request-58 Hotlist-Merge-Approved Merge-Approved-58
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 17 2017

Labels: -merge-approved-58 merge-merged-3029
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/049b2f224e9ab42fbf962a70e3a71d4fa79d4e01

commit 049b2f224e9ab42fbf962a70e3a71d4fa79d4e01
Author: khmel <khmel@chromium.org>
Date: Fri Mar 17 20:04:21 2017

[Merge M58] arc: Reactivate OptIn flow on clicking Play Store.

This fixes broken flow when ARC OptIn can be re-activated for managed
user in case user clicks Play Store icon in App Launcher or on shelf.

TEST=Manually + unit_test added
BUG= 700601 
TBR=xiyuan@chromium.org,yusukes@chromium.org,oshima@chromium.org
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2739323004
Cr-Commit-Position: refs/heads/master@{#457107}
(cherry picked from commit 919bb1a623fd23ecbcd3664ff45d63cec36da977)

Review-Url: https://codereview.chromium.org/2755073003
Cr-Commit-Position: refs/branch-heads/3029@{#275}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/049b2f224e9ab42fbf962a70e3a71d4fa79d4e01/chrome/browser/chromeos/arc/arc_session_manager.h
[modify] https://crrev.com/049b2f224e9ab42fbf962a70e3a71d4fa79d4e01/chrome/browser/chromeos/arc/arc_session_manager_unittest.cc
[modify] https://crrev.com/049b2f224e9ab42fbf962a70e3a71d4fa79d4e01/chrome/browser/chromeos/arc/arc_util.cc
[modify] https://crrev.com/049b2f224e9ab42fbf962a70e3a71d4fa79d4e01/chrome/browser/ui/app_list/arc/arc_app_utils.cc
[modify] https://crrev.com/049b2f224e9ab42fbf962a70e3a71d4fa79d4e01/chrome/browser/ui/ash/launcher/arc_playstore_shortcut_launcher_item_controller.cc
[modify] https://crrev.com/049b2f224e9ab42fbf962a70e3a71d4fa79d4e01/chrome/browser/ui/ash/launcher/arc_playstore_shortcut_launcher_item_controller.h

Comment 5 by khmel@chromium.org, Mar 17 2017

Status: Fixed (was: Started)
Status: Assigned (was: Fixed)
Playstore icon is present on shelf but missing in app launcher.

Also, nothing happens on clicking Playstore icon in shelf.

Build: 9334.23.0 / 58.0.3029.39 cyan
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b8357dd7fdc55e484b98b4f9e792e439924b81eb

commit b8357dd7fdc55e484b98b4f9e792e439924b81eb
Author: khmel <khmel@chromium.org>
Date: Tue Mar 28 17:43:30 2017

[Merge M58] arg: Enable Play Store item in App Launcher for managed case.

This fixes issue when Play Store item is not available for ARC
managed and enabled case.

NOTRY=true
NOPRESUBMIT=true
TBR=xiyuan@chromium.org

BUG= 700601 
BUG=b/36043525
TEST=Extended unit_tests
TEST=Manually on Caroline, normal case (@gmail.com), managed
     enabled (@google.com) and managed disabled (@chromium.org).

Review-Url: https://codereview.chromium.org/2738983003
Cr-Commit-Position: refs/heads/master@{#455894}
(cherry picked from commit 8d651457cff4086e56e9861bc24ae1f127b590d6)

Review-Url: https://codereview.chromium.org/2781623005
Cr-Commit-Position: refs/branch-heads/3029@{#453}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/b8357dd7fdc55e484b98b4f9e792e439924b81eb/chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc
[modify] https://crrev.com/b8357dd7fdc55e484b98b4f9e792e439924b81eb/chrome/browser/ui/app_list/arc/arc_app_list_prefs.h
[modify] https://crrev.com/b8357dd7fdc55e484b98b4f9e792e439924b81eb/chrome/browser/ui/app_list/arc/arc_app_unittest.cc
[modify] https://crrev.com/b8357dd7fdc55e484b98b4f9e792e439924b81eb/chrome/browser/ui/app_list/arc/arc_default_app_list.cc
[modify] https://crrev.com/b8357dd7fdc55e484b98b4f9e792e439924b81eb/chrome/browser/ui/app_list/arc/arc_default_app_list.h

Comment 8 by khmel@chromium.org, Mar 28 2017

Status: Fixed (was: Assigned)
#6 - sorry, forgot to merge one more required CL
Status: Verified (was: Fixed)
Chrome OS 9334.69.0, 58.0.3029.112

Sign in to add a comment