This bug tracks the modification of device/u2f/ classes from using shared_refptr to unique_ptrs when they are uniquely owned.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6de00828602a051db2bb66c17e5867b5559d2ef3 commit 6de00828602a051db2bb66c17e5867b5559d2ef3 Author: piperc <piperc@chromium.org> Date: Wed Mar 22 16:37:32 2017 Modify U2F apdu classes to use unique pointers Apdu classes will have unique ownership, so changing the classes to std::unique_ptr instead of shared_refptr. BUG= 700594 Review-Url: https://codereview.chromium.org/2743623006 Cr-Commit-Position: refs/heads/master@{#458774} [modify] https://crrev.com/6de00828602a051db2bb66c17e5867b5559d2ef3/device/u2f/u2f_apdu_command.cc [modify] https://crrev.com/6de00828602a051db2bb66c17e5867b5559d2ef3/device/u2f/u2f_apdu_command.h [modify] https://crrev.com/6de00828602a051db2bb66c17e5867b5559d2ef3/device/u2f/u2f_apdu_fuzzer.cc [modify] https://crrev.com/6de00828602a051db2bb66c17e5867b5559d2ef3/device/u2f/u2f_apdu_response.cc [modify] https://crrev.com/6de00828602a051db2bb66c17e5867b5559d2ef3/device/u2f/u2f_apdu_response.h [modify] https://crrev.com/6de00828602a051db2bb66c17e5867b5559d2ef3/device/u2f/u2f_apdu_unittest.cc [modify] https://crrev.com/6de00828602a051db2bb66c17e5867b5559d2ef3/device/u2f/u2f_device.cc [modify] https://crrev.com/6de00828602a051db2bb66c17e5867b5559d2ef3/device/u2f/u2f_device.h [modify] https://crrev.com/6de00828602a051db2bb66c17e5867b5559d2ef3/device/u2f/u2f_hid_device.cc [modify] https://crrev.com/6de00828602a051db2bb66c17e5867b5559d2ef3/device/u2f/u2f_hid_device.h [modify] https://crrev.com/6de00828602a051db2bb66c17e5867b5559d2ef3/device/u2f/u2f_hid_device_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a80b2b0045974cde9256cb838b5aeae10da1865e commit a80b2b0045974cde9256cb838b5aeae10da1865e Author: piperc <piperc@chromium.org> Date: Wed Mar 22 22:20:32 2017 Use unique pointers for U2fPacket and U2fMessage U2fMessage and U2fPacket classes will have unique ownership so changing the classes to std::unique_ptr instead of shared_refptr. BUG= 700594 Review-Url: https://codereview.chromium.org/2766723003 Cr-Commit-Position: refs/heads/master@{#458896} [modify] https://crrev.com/a80b2b0045974cde9256cb838b5aeae10da1865e/device/u2f/u2f_hid_device.cc [modify] https://crrev.com/a80b2b0045974cde9256cb838b5aeae10da1865e/device/u2f/u2f_hid_device.h [modify] https://crrev.com/a80b2b0045974cde9256cb838b5aeae10da1865e/device/u2f/u2f_message.cc [modify] https://crrev.com/a80b2b0045974cde9256cb838b5aeae10da1865e/device/u2f/u2f_message.h [modify] https://crrev.com/a80b2b0045974cde9256cb838b5aeae10da1865e/device/u2f/u2f_message_fuzzer.cc [modify] https://crrev.com/a80b2b0045974cde9256cb838b5aeae10da1865e/device/u2f/u2f_message_unittest.cc [modify] https://crrev.com/a80b2b0045974cde9256cb838b5aeae10da1865e/device/u2f/u2f_packet.cc [modify] https://crrev.com/a80b2b0045974cde9256cb838b5aeae10da1865e/device/u2f/u2f_packet.h
Comment 1 by bugdroid1@chromium.org
, Mar 22 2017