New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 700591 link

Starred by 2 users
Status: Fixed
Owner:
█ lgar...@chromium.org
Last visit > 30 days ago
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug
Team-Security-UX

Blocked on:
issue 661796


Sign in to add a comment

Run `git cl format` on page_info folders

Project Member Reported by lgar...@chromium.org, Mar 11 2017 
chrome/browser/{ui, ui/views, ui/cocoa}/website_settings are moving in  Issue 661796 .

This triggers some `git cl format` discrepancies. I'm avoiding those in in the CLs themselves, to make the moves as simple and safe as possible. But we can force `git cl format` on the full folders afterwards.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1a6300d0b8d32378cf4861f75c84010b1cafe031

commit 1a6300d0b8d32378cf4861f75c84010b1cafe031
Author: lgarron <lgarron@chromium.org>
Date: Sat Mar 18 03:33:04 2017

Run `git cl format` on all desktop page_info code.

BUG= 700591 
TBR=raymes@chromium.org

Review-Url: https://codereview.chromium.org/2741303002
Cr-Commit-Position: refs/heads/master@{#457949}

[modify] https://crrev.com/1a6300d0b8d32378cf4861f75c84010b1cafe031/chrome/browser/ui/cocoa/page_info/split_block_button.mm
[modify] https://crrev.com/1a6300d0b8d32378cf4861f75c84010b1cafe031/chrome/browser/ui/cocoa/page_info/website_settings_bubble_controller.mm
[modify] https://crrev.com/1a6300d0b8d32378cf4861f75c84010b1cafe031/chrome/browser/ui/cocoa/page_info/website_settings_bubble_controller_unittest.mm
[modify] https://crrev.com/1a6300d0b8d32378cf4861f75c84010b1cafe031/chrome/browser/ui/page_info/permission_menu_model.cc
[modify] https://crrev.com/1a6300d0b8d32378cf4861f75c84010b1cafe031/chrome/browser/ui/page_info/website_settings.cc
[modify] https://crrev.com/1a6300d0b8d32378cf4861f75c84010b1cafe031/chrome/browser/ui/page_info/website_settings.h
[modify] https://crrev.com/1a6300d0b8d32378cf4861f75c84010b1cafe031/chrome/browser/ui/page_info/website_settings_infobar_delegate.cc
[modify] https://crrev.com/1a6300d0b8d32378cf4861f75c84010b1cafe031/chrome/browser/ui/page_info/website_settings_ui.cc
[modify] https://crrev.com/1a6300d0b8d32378cf4861f75c84010b1cafe031/chrome/browser/ui/page_info/website_settings_ui.h
[modify] https://crrev.com/1a6300d0b8d32378cf4861f75c84010b1cafe031/chrome/browser/ui/page_info/website_settings_unittest.cc
[modify] https://crrev.com/1a6300d0b8d32378cf4861f75c84010b1cafe031/chrome/browser/ui/views/page_info/permission_selector_row.cc
[modify] https://crrev.com/1a6300d0b8d32378cf4861f75c84010b1cafe031/chrome/browser/ui/views/page_info/website_settings_popup_view.cc

Comment 2 by lgar...@chromium.org, May 20 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment