New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 700581 link

Starred by 2 users
Status: Fixed
Owner:
█ lgar...@chromium.org
Last visit > 30 days ago
Closed: Mar 2017
Cc:
█ raymes@chromium.org
benwells@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug
Team-Security-UX

Blocked on:
issue 661796
Blocking:
issue 700604



Sign in to add a comment

Move permission prompt UI code into a permission_bubble folder

Project Member Reported by lgar...@chromium.org, Mar 10 2017 
After I move chrome/browser/{ui, ui/views, ui/cocoa}/website_settings to chrome/browser/{ui, ui/views, ui/cocoa}/page_info ( Issue 661796  ), the website_settings folder will only contain permission prompt code. We should rename website_settings to permission_prompts once that happens.

Comment 1 by lgar...@chromium.org, Mar 11 2017

Summary: Move permission prompt UI code into a permission_bubble folder (was: Move permission prompt UI code into a permission_prompts folder)

Comment 2 by lgar...@chromium.org, Mar 11 2017

Blocking: 700604
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 16 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fab39f321bd58291b749a5654dd00eac809dd77a

commit fab39f321bd58291b749a5654dd00eac809dd77a
Author: lgarron <lgarron@chromium.org>
Date: Thu Mar 16 04:11:02 2017

Rename website_settings UI folders to permission_bubble.

BUG= 700581 
TBR=jochen@chromium.org

Review-Url: https://codereview.chromium.org/2748443005
Cr-Commit-Position: refs/heads/master@{#457349}

[modify] https://crrev.com/fab39f321bd58291b749a5654dd00eac809dd77a/chrome/browser/download/download_request_limiter_unittest.cc
[modify] https://crrev.com/fab39f321bd58291b749a5654dd00eac809dd77a/chrome/browser/geolocation/geolocation_permission_context_unittest.cc
[modify] https://crrev.com/fab39f321bd58291b749a5654dd00eac809dd77a/chrome/browser/permissions/permission_prompt_android.h
[modify] https://crrev.com/fab39f321bd58291b749a5654dd00eac809dd77a/chrome/browser/permissions/permission_request_manager.cc
[modify] https://crrev.com/fab39f321bd58291b749a5654dd00eac809dd77a/chrome/browser/permissions/permission_request_manager.h
[modify] https://crrev.com/fab39f321bd58291b749a5654dd00eac809dd77a/chrome/browser/permissions/permission_request_manager_browsertest.cc
[modify] https://crrev.com/fab39f321bd58291b749a5654dd00eac809dd77a/chrome/browser/permissions/permission_request_manager_unittest.cc
[modify] https://crrev.com/fab39f321bd58291b749a5654dd00eac809dd77a/chrome/browser/permissions/permissions_browsertest.cc
[modify] https://crrev.com/fab39f321bd58291b749a5654dd00eac809dd77a/chrome/browser/plugins/flash_permission_browsertest.cc
[modify] https://crrev.com/fab39f321bd58291b749a5654dd00eac809dd77a/chrome/browser/safe_browsing/permission_reporter_browsertest.cc
[modify] https://crrev.com/fab39f321bd58291b749a5654dd00eac809dd77a/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/fab39f321bd58291b749a5654dd00eac809dd77a/chrome/browser/ui/browser.cc
[modify] https://crrev.com/fab39f321bd58291b749a5654dd00eac809dd77a/chrome/browser/ui/cocoa/browser_window_controller.mm
[modify] https://crrev.com/fab39f321bd58291b749a5654dd00eac809dd77a/chrome/browser/ui/cocoa/browser_window_controller_private.mm
[rename] https://crrev.com/fab39f321bd58291b749a5654dd00eac809dd77a/chrome/browser/ui/cocoa/permission_bubble/OWNERS
[rename] https://crrev.com/fab39f321bd58291b749a5654dd00eac809dd77a/chrome/browser/ui/cocoa/permission_bubble/chooser_bubble_ui_cocoa.h
[rename] https://crrev.com/fab39f321bd58291b749a5654dd00eac809dd77a/chrome/browser/ui/cocoa/permission_bubble/chooser_bubble_ui_cocoa.mm
[rename] https://crrev.com/fab39f321bd58291b749a5654dd00eac809dd77a/chrome/browser/ui/cocoa/permission_bubble/permission_bubble_cocoa.h
[rename] https://crrev.com/fab39f321bd58291b749a5654dd00eac809dd77a/chrome/browser/ui/cocoa/permission_bubble/permission_bubble_cocoa.mm
[rename] https://crrev.com/fab39f321bd58291b749a5654dd00eac809dd77a/chrome/browser/ui/cocoa/permission_bubble/permission_bubble_cocoa_browser_test.mm
[rename] https://crrev.com/fab39f321bd58291b749a5654dd00eac809dd77a/chrome/browser/ui/cocoa/permission_bubble/permission_bubble_cocoa_interactive_uitest.mm
[rename] https://crrev.com/fab39f321bd58291b749a5654dd00eac809dd77a/chrome/browser/ui/cocoa/permission_bubble/permission_bubble_controller.h
[rename] https://crrev.com/fab39f321bd58291b749a5654dd00eac809dd77a/chrome/browser/ui/cocoa/permission_bubble/permission_bubble_controller.mm
[rename] https://crrev.com/fab39f321bd58291b749a5654dd00eac809dd77a/chrome/browser/ui/cocoa/permission_bubble/permission_bubble_controller_unittest.mm
[rename] https://crrev.com/fab39f321bd58291b749a5654dd00eac809dd77a/chrome/browser/ui/cocoa/permission_bubble/permission_prompt_impl_views_mac.mm
[rename] https://crrev.com/fab39f321bd58291b749a5654dd00eac809dd77a/chrome/browser/ui/permission_bubble/OWNERS
[rename] https://crrev.com/fab39f321bd58291b749a5654dd00eac809dd77a/chrome/browser/ui/permission_bubble/chooser_bubble_delegate.cc
[rename] https://crrev.com/fab39f321bd58291b749a5654dd00eac809dd77a/chrome/browser/ui/permission_bubble/chooser_bubble_delegate.h
[rename] https://crrev.com/fab39f321bd58291b749a5654dd00eac809dd77a/chrome/browser/ui/permission_bubble/mock_permission_prompt.cc
[rename] https://crrev.com/fab39f321bd58291b749a5654dd00eac809dd77a/chrome/browser/ui/permission_bubble/mock_permission_prompt.h
[rename] https://crrev.com/fab39f321bd58291b749a5654dd00eac809dd77a/chrome/browser/ui/permission_bubble/mock_permission_prompt_factory.cc
[rename] https://crrev.com/fab39f321bd58291b749a5654dd00eac809dd77a/chrome/browser/ui/permission_bubble/mock_permission_prompt_factory.h
[rename] https://crrev.com/fab39f321bd58291b749a5654dd00eac809dd77a/chrome/browser/ui/permission_bubble/permission_bubble_browser_test_util.cc
[rename] https://crrev.com/fab39f321bd58291b749a5654dd00eac809dd77a/chrome/browser/ui/permission_bubble/permission_bubble_browser_test_util.h
[rename] https://crrev.com/fab39f321bd58291b749a5654dd00eac809dd77a/chrome/browser/ui/permission_bubble/permission_prompt.h
[rename] https://crrev.com/fab39f321bd58291b749a5654dd00eac809dd77a/chrome/browser/ui/views/permission_bubble/OWNERS
[rename] https://crrev.com/fab39f321bd58291b749a5654dd00eac809dd77a/chrome/browser/ui/views/permission_bubble/chooser_bubble_ui_view.cc
[rename] https://crrev.com/fab39f321bd58291b749a5654dd00eac809dd77a/chrome/browser/ui/views/permission_bubble/chooser_bubble_ui_view.h
[rename] https://crrev.com/fab39f321bd58291b749a5654dd00eac809dd77a/chrome/browser/ui/views/permission_bubble/permission_prompt_impl.cc
[rename] https://crrev.com/fab39f321bd58291b749a5654dd00eac809dd77a/chrome/browser/ui/views/permission_bubble/permission_prompt_impl.h
[rename] https://crrev.com/fab39f321bd58291b749a5654dd00eac809dd77a/chrome/browser/ui/views/permission_bubble/permission_prompt_impl_views.cc
[modify] https://crrev.com/fab39f321bd58291b749a5654dd00eac809dd77a/chrome/browser/usb/web_usb_chooser_service.cc
[modify] https://crrev.com/fab39f321bd58291b749a5654dd00eac809dd77a/chrome/test/BUILD.gn

Comment 4 by lgar...@chromium.org, Mar 20 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment