New issue
Advanced search Search tips

Issue 700577 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Nov 15
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Feature



Sign in to add a comment

Make changes to prevent/more easily diagnose missing generated files

Project Member Reported by bsheedy@chromium.org, Mar 10 2017

Issue description

We recently spent a while diagnosing an issue with a patch that we were not able to reproduce locally or on the trybots. It turns out that it was a problem with necessary files not getting packaged after compilation, which isn't done locally or on the trybots.

The fix was a one line addition (https://chromium-review.googlesource.com/c/453099/), but diagnosing it was a pain since the error message gave no indication that this could be an issue with the build infrastructure (we thought it was an issue with some files not being built):

[7364:7468:0310/121800.244:1941125:ERROR:mojo_context_state.cc(199)] Failed to fetch source for module "gpu/ipc/common/mailbox_holder.mojom"
[7364:7468:0310/121800.244:1941125:ERROR:mojo_context_state.cc(199)] Failed to fetch source for module "gpu/ipc/common/sync_token.mojom"

This also seems to have happened in the past (https://chromium-review.googlesource.com/c/414565/), so something should probably be done to either:

- Prevent this from happening at all, e.g. packaging all of gen/, although I don't know how much that would affect size
- Make the error message hint at possible solutions, e.g. adding "Is the file in one of the directories included in build/scripts/slave/zip_build.py#_MojomFiles?" to the end.
 
Status: Fixed (was: Untriaged)
I believe this is actually fixed now that derive data dependencies from the //:webkit_layout_tests target which as, e.g., an explicit dependency on //device/vr/public/mojom:mojom_js_data_deps. AFAICT we don't rely on this external packaging script anymore.

Sign in to add a comment