CrOS currently uses gtest/gmock 1.7.0, which was released in Sep 2013. gtest/gmock 1.8.0 was released in Aug 2016, which has better support for C++11 features (e.g. move-only type).
Issue 733104 has been merged into this issue.
Mike, should I go ahead and commit the CLs? or should we still wait for upstream gentoo to pick it up first?
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/ef06aa518f93450e985963e63f9490255585b383 commit ef06aa518f93450e985963e63f9490255585b383 Author: Ben Chan <benchan@chromium.org> Date: Wed Jun 21 13:27:11 2017 dev-cpp/gtest32: upgrade to match gtest 1.8.0 dev-cpp/gtest is being upgraded to 1.8.0. This CL upgrades dev-cpp/gtest32 to match that. BUG= chromium:700573 CQ-DEPEND=CL:461730 CQ-DEPEND=CL:461731 TEST=Remote trybot runs on paladin and release builders. TEST=`USE=32bit_au FEATURES=test emerge-lumpy verity chromeos-installer` Change-Id: I8e2672d8d5cbe162bba3509ecf239cfdf85a7ec5 Reviewed-on: https://chromium-review.googlesource.com/490649 Commit-Ready: Ben Chan <benchan@chromium.org> Tested-by: Ben Chan <benchan@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> [rename] https://crrev.com/ef06aa518f93450e985963e63f9490255585b383/dev-cpp/gtest32/gtest32-1.8.0.ebuild [modify] https://crrev.com/ef06aa518f93450e985963e63f9490255585b383/dev-cpp/gtest32/Manifest [add] https://crrev.com/ef06aa518f93450e985963e63f9490255585b383/dev-cpp/gtest32/files/gtest-1.8.0-makefile-am.patch
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/5c36b4f74735c28b798120932f75ed28eba52c5e commit 5c36b4f74735c28b798120932f75ed28eba52c5e Author: Ben Chan <benchan@chromium.org> Date: Wed Jun 21 13:27:11 2017 dev-cpp/gmock32: upgrade to match gmock 1.8.0 dev-cpp/gmock is being upgraded to 1.8.0. This CL upgrades dev-cpp/gmock32 to match that. BUG= chromium:700573 CQ-DEPEND=CL:461730 CQ-DEPEND=CL:461731 TEST=Remote trybot runs on paladin and release builders. TEST=`USE=32bit_au FEATURES=test emerge-lumpy verity chromeos-installer` Change-Id: I895fba5050d981eeba261df65081e34c6ac9181d Reviewed-on: https://chromium-review.googlesource.com/490650 Commit-Ready: Ben Chan <benchan@chromium.org> Tested-by: Ben Chan <benchan@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> [modify] https://crrev.com/5c36b4f74735c28b798120932f75ed28eba52c5e/dev-cpp/gmock32/files/gtest-config [modify] https://crrev.com/5c36b4f74735c28b798120932f75ed28eba52c5e/dev-cpp/gmock32/Manifest [add] https://crrev.com/5c36b4f74735c28b798120932f75ed28eba52c5e/dev-cpp/gmock32/gmock32-1.8.0.ebuild [delete] https://crrev.com/ef06aa518f93450e985963e63f9490255585b383/dev-cpp/gmock32/gmock32-1.7.0-r1.ebuild [add] https://crrev.com/5c36b4f74735c28b798120932f75ed28eba52c5e/dev-cpp/gmock32/files/gmock-1.8.0-makefile-am.patch
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/portage-stable/+/a123793126824d8ff18ef35893b76320949dae3a commit a123793126824d8ff18ef35893b76320949dae3a Author: Ben Chan <benchan@chromium.org> Date: Wed Jun 21 13:27:10 2017 dev-cpp/gtest: upgrade to 1.8.0 BUG= chromium:700573 CQ-DEPEND=CL:490649 TEST=Remote trybot runs on paladin and release builders. Change-Id: I155628489292a46c8a551c1208e55ec6aa0aea20 Reviewed-on: https://chromium-review.googlesource.com/461730 Commit-Ready: Ben Chan <benchan@chromium.org> Tested-by: Ben Chan <benchan@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> [modify] https://crrev.com/a123793126824d8ff18ef35893b76320949dae3a/dev-cpp/gtest/Manifest [add] https://crrev.com/a123793126824d8ff18ef35893b76320949dae3a/dev-cpp/gtest/gtest-1.8.0.ebuild [delete] https://crrev.com/c4ade0e59beb2c25ed6df60643df60d5a9cc0882/dev-cpp/gtest/gtest-1.7.0.ebuild [add] https://crrev.com/a123793126824d8ff18ef35893b76320949dae3a/dev-cpp/gtest/files/gtest-1.8.0-makefile-am.patch
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/portage-stable/+/3a78af6901abd96452d3a42bf5c616d3c6df2d3e commit 3a78af6901abd96452d3a42bf5c616d3c6df2d3e Author: Ben Chan <benchan@chromium.org> Date: Wed Jun 21 13:27:11 2017 dev-cpp/gmock: upgrade to 1.8.0 BUG= chromium:700573 CQ-DEPEND=CL:490649 CQ-DEPEND=CL:490650 TEST=Remote trybot runs on paladin and release builders. Change-Id: If5ddd2f645419a63bfe7dac171c728646ac9ed9b Reviewed-on: https://chromium-review.googlesource.com/461731 Commit-Ready: Ben Chan <benchan@chromium.org> Tested-by: Ben Chan <benchan@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> [delete] https://crrev.com/a123793126824d8ff18ef35893b76320949dae3a/dev-cpp/gmock/files/gmock-1.4.0-more-gcc-4.7.patch [delete] https://crrev.com/a123793126824d8ff18ef35893b76320949dae3a/dev-cpp/gmock/files/gmock-1.4.0-gcc-4.7.patch [add] https://crrev.com/3a78af6901abd96452d3a42bf5c616d3c6df2d3e/dev-cpp/gmock/gmock-1.8.0.ebuild [modify] https://crrev.com/3a78af6901abd96452d3a42bf5c616d3c6df2d3e/dev-cpp/gmock/Manifest [add] https://crrev.com/3a78af6901abd96452d3a42bf5c616d3c6df2d3e/dev-cpp/gmock/files/gmock-1.8.0-makefile-am.patch
Comment 1 by benchan@chromium.org
, Mar 29 2017Status: Started (was: Untriaged)