New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 700570 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit 29 days ago
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

DevTools: console suggestbox behaves inconsistently with other suggestboxes

Project Member Reported by lushnikov@chromium.org, Mar 10 2017

Issue description

Chrome Version       : 56.0.2924.87

What steps will reproduce the problem?
1. Open devtools
2. Open console
3. Type "w". Suggest box appears, showing "window" suggestion preselected. 
4. Hit enter.

Expected: the suggestion gets applied
Actual: the "w" is executed.

On the contrary, all other suggest boxes in devtools apply suggestion which is selected in blue.
 
This behavior was introduced in 
https://codereview.chromium.org/1611783002/ and is confusing.
Started: https://codereview.chromium.org/2742573007

greyd-out-suggest-in-console.png
68.0 KB View Download
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a54a48cb6f59fe24dd4a4e566d42c9f059e9e242

commit a54a48cb6f59fe24dd4a4e566d42c9f059e9e242
Author: lushnikov <lushnikov@chromium.org>
Date: Sat Mar 11 17:50:32 2017

DevTools: initial console suggestion should be greyed out

This patch makes initial console suggestion greyed out until
user explicitly interactes with the suggest box.

BUG= 700570 
R=dgozman, pfeldman, einbinder

Review-Url: https://codereview.chromium.org/2742573007
Cr-Commit-Position: refs/heads/master@{#456283}

[modify] https://crrev.com/a54a48cb6f59fe24dd4a4e566d42c9f059e9e242/third_party/WebKit/Source/devtools/front_end/text_editor/TextEditorAutocompleteController.js
[modify] https://crrev.com/a54a48cb6f59fe24dd4a4e566d42c9f059e9e242/third_party/WebKit/Source/devtools/front_end/ui/SuggestBox.js
[modify] https://crrev.com/a54a48cb6f59fe24dd4a4e566d42c9f059e9e242/third_party/WebKit/Source/devtools/front_end/ui/suggestBox.css

do-not-clash-colors.png
4.3 KB View Download
Status: Fixed (was: Assigned)

Sign in to add a comment